Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: accountQuota does not take effect due to race condition #1564

Merged
merged 4 commits into from
Nov 18, 2023

Conversation

andyzhangx
Copy link
Member

@andyzhangx andyzhangx commented Nov 11, 2023

What type of PR is this?
/kind bug

What this PR does / why we need it:
fix: accountQuota does not take effect due to race condition

Which issue(s) this PR fixes:

Fixes #1556

Requirements:

Special notes for your reviewer:

Release note:

fix: accountQuota does not take effect due to race condition

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 11, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 11, 2023
@andyzhangx andyzhangx changed the title [WIP]fix: add lock to avoid concurrent update on the cache fix: add lock to avoid concurrent update on the cache Nov 17, 2023
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 17, 2023
@andyzhangx andyzhangx changed the title fix: add lock to avoid concurrent update on the cache fix: accountQuota does not take effect due to race condition Nov 17, 2023
@andyzhangx
Copy link
Member Author

/retest

3 similar comments
@andyzhangx
Copy link
Member Author

/retest

@andyzhangx
Copy link
Member Author

/retest

@andyzhangx
Copy link
Member Author

/retest

@andyzhangx andyzhangx merged commit 0aef889 into master Nov 18, 2023
@andyzhangx
Copy link
Member Author

/cherrypick release-1.29

@k8s-infra-cherrypick-robot

@andyzhangx: #1564 failed to apply on top of branch "release-1.29":

Applying: test: add accountQuota e2e test
Using index info to reconstruct a base tree...
M	test/e2e/dynamic_provisioning_test.go
Falling back to patching base and 3-way merge...
Auto-merging test/e2e/dynamic_provisioning_test.go
CONFLICT (content): Merge conflict in test/e2e/dynamic_provisioning_test.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 test: add accountQuota e2e test
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-1.29

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

accountQuota SC parameter causes client throttling
3 participants