Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ErrFsExistsDiffSize error on incompatible parameter #322

Merged
merged 1 commit into from
May 30, 2023

Conversation

jacobwolfaws
Copy link
Contributor

@jacobwolfaws jacobwolfaws commented May 30, 2023

Is this a bug fix or adding new feature?
bug fix
What is this PR about? / Why do we need it?
This PR is meant to address this issue: #288
Right now an incompatible parameter error (like specifying throughput for SCRATCH_2), returns a ErrFsExistsDiffSize error. This error is both 1) wrong and 2) not descriptive for users to mitigate this issue. This PR just removes the if statement completely & associated function completely, so users get a descriptive error output. ex:

"GRPC error" err=<
	rpc error: code = Internal desc = Could not create volume "pvc-example_pvc": CreateFileSystem failed: IncompatibleParameterError: The storage throughput can not be specified for a lustre file system with DeploymentType=SCRATCH_2
	{
	  RespMetadata: {
	    StatusCode: 400,
	    RequestID: "example_request"
	  },
	  Message_: "The storage throughput can not be specified for a lustre file system with DeploymentType=SCRATCH_2"
	}
 >

What testing is done?

  • tested with storageclass that tries to specify throughput for scratch
  • sanity testing

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 30, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jacobwolfaws

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from olemarkus and wongma7 May 30, 2023 15:13
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 30, 2023
@jacobwolfaws
Copy link
Contributor Author

jacobwolfaws commented May 30, 2023

/retest

stuck in pending, trying this to mitigate

@jacobwolfaws
Copy link
Contributor Author

/test all

@jacobwolfaws
Copy link
Contributor Author

jacobwolfaws commented May 30, 2023

kubernetes/test-infra#29622 Appears to be related to the stuck tests

@jacobwolfaws
Copy link
Contributor Author

/retest

@khoang98
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 30, 2023
@k8s-ci-robot k8s-ci-robot merged commit 1965caa into kubernetes-sigs:master May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants