-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ExpandVolume (storage scaling) features, tests, and deployment artifacts #209
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @jmwurst! |
Hi @jmwurst. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I signed it |
/ok-to-test |
@@ -175,6 +175,7 @@ var csiTestSuites = []func() testsuites.TestSuite{ | |||
testsuites.InitSubPathTestSuite, | |||
testsuites.InitProvisioningTestSuite, | |||
//testsuites.InitSnapshottableTestSuite, | |||
testsuites.InitVolumeExpandTestSuite, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are being skipped because they depend on our test declaring that the driver supports dynamic provisioning (see the commented code block above). https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_aws-fsx-csi-driver/209/pull-aws-fsx-csi-driver-e2e/1446485838421561344 skipped tests, 'AWS FSx CSI Driver End-to-End Tests: FSx CSI Driver Conformance [Driver: fsx.csi.aws.com] [Testpattern: Dynamic PV (default fs)(allowExpansion)] volume-expand Verify if offline PVC expansion works' is among them.
As long as you have tested the feature end-to-end on your own cluster I do not think this issue should block the PR. I am just pointing it out so we can remember to set up this CI testing in the future. It should be part of the larger effort to untangle the test/e2e directory and its dynamic provisioning tests to improve e2e coverage. #189
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/check-cla |
/lgtm |
@wuxingro: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jmwurst, wongma7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Is this a bug fix or adding new feature?
New feature
What is this PR about? / Why do we need it?
What testing is done?
make test
and live testing with FSx/EKS