Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to use kustomize #122

Merged
merged 1 commit into from
Dec 19, 2019
Merged

Switch to use kustomize #122

merged 1 commit into from
Dec 19, 2019

Conversation

leakingtapan
Copy link
Contributor

Is this a bug fix or adding new feature?

  • Switch to use kustomize
  • enable leader election

Fixes: #80 #91

/cc @wongma7

@k8s-ci-robot k8s-ci-robot requested a review from wongma7 December 17, 2019 22:54
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 17, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leakingtapan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 17, 2019
@leakingtapan leakingtapan force-pushed the kustomize branch 2 times, most recently from 67c1f42 to 9b89635 Compare December 17, 2019 23:33
@leakingtapan
Copy link
Contributor Author

/retest

@leakingtapan leakingtapan merged commit bbfa0f5 into kubernetes-sigs:master Dec 19, 2019
@leakingtapan leakingtapan deleted the kustomize branch December 19, 2019 19:33
@Jeffwan Jeffwan mentioned this pull request Feb 26, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wongma7 wongma7 Awaiting requested review from wongma7

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable leader election
2 participants
@leakingtapan @k8s-ci-robot