This repository has been archived by the owner on Oct 21, 2020. It is now read-only.
Fixed nfs-client Makefile, so that it builds on osx #661
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make fails on osx with the following error:
This PR updates the Makefile so that the nfs-client-provisioner builds on osx.
I removed the unnecessary
sudo
before the docker commands.Additionally, I added
GOOS=linux
and compiler arguments to statically link the binaries in the build commands.