Skip to content
This repository has been archived by the owner on Oct 21, 2020. It is now read-only.

Fixed nfs-client Makefile, so that it builds on osx #661

Merged
merged 1 commit into from
Mar 19, 2018

Conversation

ianchakeres
Copy link
Contributor

Make fails on osx with the following error:

cd nfs-client; \
	make container
CGO_ENABLED=0 go build -o docker/x86_64/nfs-client-provisioner ./cmd/nfs-client-provisioner
sudo docker build -t quay.io/external_storage/nfs-client-provisioner:latest docker/x86_64
Password:

This PR updates the Makefile so that the nfs-client-provisioner builds on osx.

I removed the unnecessary sudo before the docker commands.

Additionally, I added GOOS=linux and compiler arguments to statically link the binaries in the build commands.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 11, 2018
@ianchakeres ianchakeres added area/nfs-client and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 11, 2018
@ianchakeres
Copy link
Contributor Author

/assign @wongma7 @salkin

@k8s-ci-robot
Copy link
Contributor

@ianchakeres: GitHub didn't allow me to assign the following users: salkin.

Note that only kubernetes-incubator members and repo collaborators can be assigned.

In response to this:

/assign @wongma7 @salkin

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ianchakeres ianchakeres added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 11, 2018
@wongma7 wongma7 added the lgtm Indicates that a PR is ready to be merged. label Mar 19, 2018
@wongma7 wongma7 merged commit 34d3c44 into kubernetes-retired:master Mar 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/nfs-client cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants