Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Test PR jobs with release-tools/prow.sh snapshotter rbac fix #299

Closed
wants to merge 2 commits into from
Closed

[WIP] Test PR jobs with release-tools/prow.sh snapshotter rbac fix #299

wants to merge 2 commits into from

Conversation

ggriffiths
Copy link
Member

Signed-off-by: Grant Griffiths grant@portworx.com

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@k8s-ci-robot
Copy link
Contributor

@ggriffiths: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 16, 2020
@k8s-ci-robot k8s-ci-robot requested review from pohly and saad-ali April 16, 2020 02:21
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ggriffiths
To complete the pull request process, please assign lpabon
You can assign the PR to them by writing /assign @lpabon in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ggriffiths ggriffiths changed the title Test PR jobs with release-tools/prow.sh snapshotter rbac fix [WIP] Test PR jobs with release-tools/prow.sh snapshotter rbac fix Apr 16, 2020
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Apr 16, 2020
@ggriffiths ggriffiths mentioned this pull request Apr 16, 2020
Merged
ggriffiths
ggriffiths commented Apr 16, 2020
View reviewed changes
release-tools/prow.sh Outdated
@@ -1064,15 +1064,21 @@ main () {
docker tag "$i:latest" "$i:csiprow" || die "tagging the locally built container image for $i failed"
done

if [ -e deploy/kubernetes/rbac.yaml ]; then
if [ -e "$(pwd)/deploy/kubernetes/rbac.yaml" ] || [ -e "$(pwd)/deploy/kubernetes/csi-snapshotter/rbac-csi-snapshotter.yaml" ]; then
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this check: if [ -e deploy/kubernetes/rbac.yaml ]; does not work without $(pwd), so this code path wasn't being executed. Also, we needed to adjust for the snapshot-controller by removing it from cmds

@ggriffiths ggriffiths force-pushed the test_snapshotter_rbac_pr_changes branch from 57b3b9c to 9fcefce Compare April 16, 2020 03:11
@ggriffiths ggriffiths mentioned this pull request Apr 16, 2020
Merged
@ggriffiths
Copy link
Member Author

/retest

1 similar comment
@ggriffiths
Copy link
Member Author

/retest

@ggriffiths ggriffiths mentioned this pull request Apr 16, 2020
Merged
@ggriffiths ggriffiths force-pushed the test_snapshotter_rbac_pr_changes branch 2 times, most recently from 9c01863 to b47d481 Compare April 20, 2020 07:21
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 20, 2020
@ggriffiths ggriffiths force-pushed the test_snapshotter_rbac_pr_changes branch from b47d481 to 1eb6fee Compare April 20, 2020 07:22
@ggriffiths
Add prow.sh test changes
74b554b 
Signed-off-by: Grant Griffiths <grant@portworx.com>
@ggriffiths ggriffiths force-pushed the test_snapshotter_rbac_pr_changes branch from 5e243a9 to 74b554b Compare April 20, 2020 20:04
@k8s-ci-robot
Copy link
Contributor

@ggriffiths: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubernetes-csi-external-snapshotter-unit 74b554b link /test pull-kubernetes-csi-external-snapshotter-unit

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ggriffiths ggriffiths closed this Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pohly pohly Awaiting requested review from pohly

@saad-ali saad-ali Awaiting requested review from saad-ali

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ggriffiths @k8s-ci-robot