Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix controller publish in readonly mode #141

Merged
merged 1 commit into from
Nov 28, 2018
Merged

Fix controller publish in readonly mode #141

merged 1 commit into from
Nov 28, 2018

Conversation

wnxn
Copy link
Contributor

@wnxn wnxn commented Nov 22, 2018

Plugin's PUBLISH_READONLY capability should be verified
before publishing volume in readonly mode.

Fix controller publish in readonly mode
a2cf7d2 
Plugin's PUBLISH_READONLY capability should be verified
before publishing volume in readonly mode.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 22, 2018
@k8s-ci-robot k8s-ci-robot requested review from lpabon and pohly November 22, 2018 07:32
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 22, 2018
@wnxn
Copy link
Contributor Author

wnxn commented Nov 23, 2018 •
edited
Loading

/assign @saad-ali

@wnxn
Copy link
Contributor Author

wnxn commented Nov 28, 2018

/assign @pohly
/assign @lpabon
Would you please review this PR ?

@pohly
Copy link
Contributor

pohly commented Nov 28, 2018

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 28, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pohly, wnxn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 28, 2018
@k8s-ci-robot k8s-ci-robot merged commit a0d0221 into kubernetes-csi:master Nov 28, 2018
@wnxn wnxn deleted the readonly-publish branch December 4, 2018 13:52
suneeth51 pushed a commit to suneeth51/csi-test that referenced this pull request Sep 11, 2019
@k8s-ci-robot
Merge pull request kubernetes-csi#141 from wnxn/readonly-publish
484b2c3 
Fix controller publish in readonly mode
stmcginnis pushed a commit to stmcginnis/csi-test that referenced this pull request Oct 9, 2024
@k8s-ci-robot
Merge pull request kubernetes-csi#141 from pohly/prune-replace-optional
fc29fdd 
go-get-kubernetes.sh: make replace statement pruning optional
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpabon lpabon Awaiting requested review from lpabon

@pohly pohly Awaiting requested review from pohly

Assignees

@pohly pohly

@lpabon lpabon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wnxn @pohly @k8s-ci-robot @lpabon