Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pull-test.sh: fix "git subtree pull" errors #264

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

pohly
Copy link
Contributor

@pohly pohly commented Nov 19, 2024

Without allowing to fetch missing file content, "git subtree pull" fails:

remote: warning: lazy fetching disabled; some objects may not be available
remote: fatal: could not fetch b18c53581356c52a220a2baf1c8cf3fd9c57dda6 from promisor remote
error: git upload-pack: git-pack-objects died with error.
fatal: git upload-pack: aborting due to possible repository corruption on the remote side.
remote: aborting due to possible repository corruption on the remote side.�
fatal: protocol error: bad pack header

Without allowing to fetch missing file content, "git subtree pull" fails:

    remote: warning: lazy fetching disabled; some objects may not be available
    remote: fatal: could not fetch b18c53581356c52a220a2baf1c8cf3fd9c57dda6 from promisor remote
    error: git upload-pack: git-pack-objects died with error.
    fatal: git upload-pack: aborting due to possible repository corruption on the remote side.
    remote: aborting due to possible repository corruption on the remote side.�
    fatal: protocol error: bad pack header
@k8s-ci-robot k8s-ci-robot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Nov 19, 2024
@k8s-ci-robot k8s-ci-robot requested a review from humblec November 19, 2024 11:23
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pohly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 19, 2024
@pohly
Copy link
Contributor Author

pohly commented Nov 19, 2024

I don't know yet whether this is sufficient... let's see.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 19, 2024
@pohly
Copy link
Contributor Author

pohly commented Nov 19, 2024

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 19, 2024
@pohly
Copy link
Contributor Author

pohly commented Nov 19, 2024

/assign @huww98

@k8s-ci-robot
Copy link
Contributor

@pohly: GitHub didn't allow me to assign the following users: huww98.

Note that only kubernetes-csi members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @huww98

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@pohly
Copy link
Contributor Author

pohly commented Nov 19, 2024

/assign @jsafrane

@k8s-ci-robot
Copy link
Contributor

@pohly: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-csi-release-tools-csi-test a8b3d05 link false /test pull-kubernetes-csi-release-tools-csi-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jsafrane
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 19, 2024
@jsafrane
Copy link
Contributor

It needs also a new go + re-vendoring. I think we can add those to #261

@huww98
Copy link
Contributor

huww98 commented Nov 19, 2024

It needs also a new go + re-vendoring. I think we can add those to #261

The go.mod that needs update is located at csi-test repo. So I think it cannot be fixed by PR in this repo.

@pohly
Copy link
Contributor Author

pohly commented Nov 19, 2024

I agree that the failure in pull-kubernetes-csi-release-tools-csi-test can be ignored. That job is intentionally declared as "not required". The vendoring issue needs to be sorted out when updating csi-release-tools in the csi-test repo.

I don't know what Trivy is complaining about. It seems to block merging?

@huww98
Copy link
Contributor

huww98 commented Nov 19, 2024

It seems my PR #261 is not triggering Trivy, because it is awaiting approval. So, I can work around this 😂

I've rebased #261 onto #264 .

@huww98 huww98 mentioned this pull request Nov 19, 2024
@k8s-ci-robot k8s-ci-robot merged commit a8b3d05 into kubernetes-csi:master Nov 19, 2024
6 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants