Document structs used in API group interfaces #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c5ad275 to
19f67d3
Compare
19f67d3 to
3f6d00f
Compare
|
/cc @mauriciopoppe Again, sorry about the force pushing. Still learning my way around rebasing and force pushing. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexander-ding, mauriciopoppe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@mauriciopoppe could you close #232. I put the wrong fixes # in the description at first (referenced a closed issue). I edited the description to match the issue we actually are fixing here, but you need to manually close #232. |
dfajmon
added a commit
to dfajmon/csi-proxy
that referenced
this pull request
Dec 19, 2024
0496593 Merge pull request kubernetes-csi#268 from huww98/cloudbuild 119aee1 Merge pull request kubernetes-csi#266 from jsafrane/bump-sanity-5.3.1 0ae5e52 Update cloudbuild image with go 1.21+ 406a79a Merge pull request kubernetes-csi#267 from huww98/gomodcache 9cec273 Set GOMODCACHE to avoid re-download toolchain 43bde06 Bump csi-sanity to 5.3.1 git-subtree-dir: release-tools git-subtree-split: 04965932661b6e62709dcdbb9c25da528bac2605
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Documents API structs that are now user facing.
Which issue(s) this PR fixes:
Fixes #232
Special notes for your reviewer:
Does this PR introduce a user-facing change?: