test: select node for late binding tests #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The generic ephemeral volume test runs with a variant that uses late binding and that failed when the selected node didn't have the driver: E0301 08:28:16.192962 1 controller.go:984] error syncing claim "17c6176b-3ea7-4363-bc35-eb25c2c20f4e": failed to provision volume with StorageClass "ephemeral-9299-e2e-scmtzhx": error generating accessibility requirements: no topology key found on CSINode csi-prow-worker2 The in-tree hostpath driver deployment avoids that by setting the node on which test pods may run: https://github.com/kubernetes/kubernetes/blob/793390e13be91d79150b57abad5710477ab96bd7/test/e2e/storage/drivers/csi.go#L193 We need to do the same when testing the driver externally.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jsafrane, pohly The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
humblec
added a commit
to humblec/csi-driver-host-path
that referenced
this pull request
May 24, 2024
4967685 Merge pull request kubernetes-csi#254 from bells17/add-github-actions d9bd160 Update skip list in codespell GitHub Action adb3af9 Merge pull request kubernetes-csi#252 from bells17/update-go-version f5aebfc Add GitHub Actions workflows b82ee38 Merge pull request kubernetes-csi#253 from bells17/fix-typo c317456 Fix typo 0a78505 Bump to Go 1.22.3 edd89ad Merge pull request kubernetes-csi#251 from jsafrane/add-logcheck 043fd09 Add test-logcheck target d7535ae Merge pull request kubernetes-csi#250 from jsafrane/go-1.22 b52e7ad Update go to 1.22.2 14fdb6f Merge pull request kubernetes-csi#247 from msau42/prow 9b4352e Update release playbook c7bb972 Fix release notes script to use fixed tags 463a0e9 Add script to update specific go modules git-subtree-dir: release-tools git-subtree-split: 4967685
TerryHowe
pushed a commit
to TerryHowe/csi-driver-host-path
that referenced
this pull request
Oct 17, 2024
Update go to 1.22.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind failing-test
What this PR does / why we need it:
The generic ephemeral volume test runs with a variant that uses late
binding and that failed when the selected node didn't have the driver:
The in-tree hostpath driver deployment avoids that by setting the node
on which test pods may run:
https://github.com/kubernetes/kubernetes/blob/793390e13be91d79150b57abad5710477ab96bd7/test/e2e/storage/drivers/csi.go#L193
We need to do the same when testing the driver externally.
Which issue(s) this PR fixes:
https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/ci-kubernetes-csi-alpha-canary-on-kubernetes-master/1366289824465555456
Does this PR introduce a user-facing change?: