-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update examples #922
Update examples #922
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want to rework the yaml example though? Or are you using automodule on the utils/ package? I don’t think we have documentation about the creation from yaml otherwise
@micw523 can you be more specific please with your comment? I don't want to address all examples at once. |
I just saw that you took off the yaml example. However Sphinx allows us to create automated documentation of the utils/ folder and package with automodule/autoclass. I was wondering if that was your intention after removing the yaml example. |
@micw523 that was not my intention. This pull request is only about updating the examples. I also included them in the sphinx docs. |
This sounds good to me. @roycaihw what do you think? |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: oz123, roycaihw The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is a partial fix for #884 which addresses the first two bullet points.