Release 10.0.0 #864
Merged
Release 10.0.0 #864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mail_scope_to_gcp_credentials_refresh_submodule Updating Submodule for GCP Email Scope Addition
All our libraries that depended on `kubernetes` started breaking today. The reason is that pip does not do a good job properly resolving the compatible package versions. It just install packages in order without caring about the incompatibilities. The urllib3 package installed is incompatible with the `requests` package that's getting installed later. Changing the order fixes the issue.
Correct inconsistent spacing and typos
Fix broken dependencies.
…yaml-namespaced Add method to dynamically set namespace in yaml files
Sometimes, minikube lags behind kubernetes which can lead to a breakage of the test suite, since minikube will fail to start with the latest kubernetes version. See for example [this issue](kubernetes/minikube#4371). This change defaults to leave the decision of which k8s version to use, to minikube itself. This is defined in: https://github.com/kubernetes/minikube/master/pkg/minikube/constants/constants.go However, if one really desires it is still possible to pass `--kubernetes-version=X.Y.Z` to minikube initialization start command via an environment variable before invoking the test suite: export $MINIKUBE_ARGS="--kubernetes-version=X.Y.Z" This allows ofcourse passing other flags to minikube also.
…-k8s-version Don't use latest stable version for minikube
Prepare master branch for 10.0.0 release
yliaog
reviewed
Jul 2, 2019
| @@ -8,6 +8,9 @@ | |||
| **New Feature:** | |||
| - Add method to dynamically set namespace in yaml utility [kubernetes-client/python#782](https://github.com/kubernetes-client/python/pull/782) | |||
|
|
|||
| **API Change:** | |||
There was a problem hiding this comment.
why is this happening on the release branch, not on master?
There was a problem hiding this comment.
it was merged yesterday kubernetes-client/gen#119 and gets included today since we pull the latest kubernetes-client/gen. It's a backwards-compatible fix IMO, so I keep it here. The master branch will sync up when we re-generate client there next time (11.0.0a1)
alternatively I can pin kubernetes-client/gen to exclude this change for this release. WDYT?
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: roycaihw, yliaog The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/assign @yliaog