Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding proxy headers options for configurations. #779

Merged
merged 1 commit into from
Mar 15, 2019

Conversation

chowmean
Copy link
Contributor

This PR addresses #735

Added options to pass proxy headers in Configuration objects and then pass it to proxy_manager in RESTClientObject.

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Mar 15, 2019
@k8s-ci-robot k8s-ci-robot requested review from lavalamp and yliaog March 15, 2019 19:18
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 15, 2019
@yliaog
Copy link
Contributor

yliaog commented Mar 15, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 15, 2019
@chowmean
Copy link
Contributor Author

I signed it

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 15, 2019
@yliaog
Copy link
Contributor

yliaog commented Mar 15, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chowmean, yliaog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 15, 2019
@k8s-ci-robot k8s-ci-robot merged commit 374233d into kubernetes-client:master Mar 15, 2019
Copy link
Member

@tomplus tomplus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm afraid these files are generated by swagger-codegen.

@chowmean
Copy link
Contributor Author

I'm afraid these files are generated by swagger-codegen.

@tomplus created this in upstream. swagger-api/swagger-codegen#9278

@chowmean
Copy link
Contributor Author

OpenAPITools/openapi-generator#2467 Added this in openapi-generators for your plan to migrate to open api generator

@tdevilleduc
Copy link

I cannot find this pull request merged in master branch
It seems this commit has erased the pull request code :
b603b4a#diff-fe9854b0d36c4421253521aa342e6276

@micw523
Copy link
Contributor

micw523 commented Dec 17, 2019

The PR author changed a file in the automatically generated codes so that the change is overwritten in the next release. The Openapi generator PR is merged however so that the change should be carried on forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants