-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to use server_side_apply to utils.create_from_yaml #2252
Conversation
The committers listed above are authorized under a signed CLA. |
Welcome @dcmcand! |
@yliaog, is there anything I can do to help get this looked at? |
When should i expect this to be released? |
sure, i'll take a look in the next couple of days. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dcmcand, yliaog The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is beautiful. I tried pip: https://stackoverflow.com/questions/20101834/pip-install-from-git-repo-branch |
@yliaog this change is incredibly useful, is there a chance there could be a |
https://github.com/kubernetes/sig-release/tree/master/releases/release-1.32 it will be included in 1.32 release, which is coming soon. |
Great news! Thank you for the update! |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Allows
utils.create_from_yaml
functions to optionally use server side apply. This is a feature that has been requested numerous times. It will allow applying a manifest more than once without throwing an error or updating manifests and reapplying (similar to howkubectl apply
works).Which issue(s) this PR fixes:
Fixes #2251
Addresses #2030
Part of #1737
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: