Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch_namespaced_config_map merge-patch #968

Closed
jicowan opened this issue Sep 25, 2019 · 6 comments
Closed

patch_namespaced_config_map merge-patch #968

jicowan opened this issue Sep 25, 2019 · 6 comments
Assignees
Labels
kind/documentation Categorizes issue or PR as related to documentation. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@jicowan
Copy link

jicowan commented Sep 25, 2019

Description of the issue (please include outputs or screenshots if possible):
I am trying to patch a configmap that has two elements: roles and users.

roles: |
   - some values
users: |
   - some values

I want to remove the element users from the configmap when the value is null. The default patch strategy appears to be a strategic merge, but I want to do a regular merge patch. How do you specify the merge strategy when you call the patch_namespaced_config_map() API? Do you have to use patch_namespaced_config_map_with_http_info? And if so, how do you pass the merge strategy to it?

@jicowan jicowan added the kind/documentation Categorizes issue or PR as related to documentation. label Sep 25, 2019
@roycaihw
Copy link
Member

roycaihw commented Oct 1, 2019

This is a known issue. There is a PR proposing a fix: #959

@yliaog
Copy link
Contributor

yliaog commented Oct 8, 2019

/assign @roycaihw

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 6, 2020
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 5, 2020
@roycaihw
Copy link
Member

Closing this issue as a dup. Tracking the fix in #959

/close

@k8s-ci-robot
Copy link
Contributor

@roycaihw: Closing this issue.

In response to this:

Closing this issue as a dup. Tracking the fix in #959

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation Categorizes issue or PR as related to documentation. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

5 participants