-
Notifications
You must be signed in to change notification settings - Fork 183
Replace base64.decodestring for base64.standard_b64decode #90
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Codecov Report
@@ Coverage Diff @@
## master #90 +/- ##
===========================================
- Coverage 91.71% 47.13% -44.59%
===========================================
Files 13 13
Lines 1135 1135
===========================================
- Hits 1041 535 -506
- Misses 94 600 +506
Continue to review full report at Codecov.
|
thanks for the PR, could you please add the reasoning for the change in the description section of this PR? |
@yliaog did it. Thanks! =) |
thanks for the description, could you please make "Issue #634" point to the issue? |
@yliaog Thanks for your attention. Done. |
could you make fixes in the test below too? also Issue #634 points to issue 60, I'm curious where the number #634 come from? |
@yliaog thanks for the help! I fixed the test and renamed the link. Sorry about the #634 , I confused it with some other issue. Do you want me to open a nem PR with the right name for the commit? |
config/kube_config_test.py
Outdated
@@ -40,7 +40,7 @@ | |||
|
|||
|
|||
def _base64(string): | |||
return base64.encodestring(string.encode()).decode() | |||
return base64.standard_b64decode(string.encode()).decode() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i guess you mean to use standard_b64encode
no need for new PR, could you squash the two commits into one? |
…ncode and standard_b64decode.
@yliaog I did it. But one of the unit tests (test_data_given_file) failed. So I replaced |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dechristo, roycaihw The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fix deprecation warning from kube_config.py (Issue #60)