Skip to content
This repository has been archived by the owner on Mar 13, 2022. It is now read-only.

Replace base64.decodestring for base64.standard_b64decode #90

Merged
merged 1 commit into from
Oct 10, 2018

Conversation

dechristo
Copy link
Contributor

@dechristo dechristo commented Oct 4, 2018

Fix deprecation warning from kube_config.py (Issue #60)

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 4, 2018
@codecov-io
Copy link

codecov-io commented Oct 4, 2018

Codecov Report

Merging #90 into master will decrease coverage by 44.58%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #90       +/-   ##
===========================================
- Coverage   91.71%   47.13%   -44.59%     
===========================================
  Files          13       13               
  Lines        1135     1135               
===========================================
- Hits         1041      535      -506     
- Misses         94      600      +506
Impacted Files Coverage Δ
config/kube_config.py 19.67% <ø> (-64.27%) ⬇️
config/kube_config_test.py 7.34% <100%> (-86.45%) ⬇️
config/dateutil.py 86.66% <0%> (-6.67%) ⬇️
config/exec_provider.py 80.43% <0%> (-2.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d1e449...260d257. Read the comment docs.

@yliaog
Copy link
Contributor

yliaog commented Oct 4, 2018

thanks for the PR, could you please add the reasoning for the change in the description section of this PR?

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Oct 4, 2018
@dechristo
Copy link
Contributor Author

@yliaog did it. Thanks! =)

@yliaog
Copy link
Contributor

yliaog commented Oct 5, 2018

thanks for the description, could you please make "Issue #634" point to the issue?

@dechristo
Copy link
Contributor Author

@yliaog Thanks for your attention. Done.

@yliaog
Copy link
Contributor

yliaog commented Oct 8, 2018

could you make fixes in the test below too?
https://github.com/kubernetes-client/python-base/blob/master/config/kube_config_test.py

also Issue #634 points to issue 60, I'm curious where the number #634 come from?

@dechristo
Copy link
Contributor Author

dechristo commented Oct 9, 2018

@yliaog thanks for the help! I fixed the test and renamed the link. Sorry about the #634 , I confused it with some other issue. Do you want me to open a nem PR with the right name for the commit?

@@ -40,7 +40,7 @@


def _base64(string):
return base64.encodestring(string.encode()).decode()
return base64.standard_b64decode(string.encode()).decode()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i guess you mean to use standard_b64encode

@yliaog
Copy link
Contributor

yliaog commented Oct 9, 2018

no need for new PR, could you squash the two commits into one?

@dechristo
Copy link
Contributor Author

@yliaog I did it. But one of the unit tests (test_data_given_file) failed. So I replaced base64.encodestring for base64.standard_b64encode in kube_config.py

@yliaog
Copy link
Contributor

yliaog commented Oct 10, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 10, 2018
@roycaihw
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dechristo, roycaihw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 10, 2018
@k8s-ci-robot k8s-ci-robot merged commit 2d514ce into kubernetes-client:master Oct 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants