Add E2E test to python-base

[mitar]

Instead of mocked API. To really test if things work. There is now kind which can help setup a Kubernetes cluster inside a CI against which then to test.

[micw523]

It's finally arrived for k8s 1.11+...

Yet we've set up the environment for the main repo. It's using minikube inside the CI to run the tests under e2e_test. If you want to make sure it works, you could potentially put some tests there.

[roycaihw]

we have e2e env set up in the main repo and we do run all tests from both repos in python-base CI (e.g. search for "e2e" here)

I think we could add e2e tests in base repo without extra env change. Question is how we manage dependency and packaging for the tests

[roycaihw]

on the other hand we can improve https://github.com/kubernetes-client/python/blob/master/kubernetes/e2e_test/test_client.py to test watch/follow behavior after #93 is included in the main repo

[micw523]

If we add e2e tests to the main repo, we'll need to potentially merge a feature / bug fix PR to the base repo first, then check in the base repo commit and the e2e test into the main repo at the same time. It's kind of a pain but it's not impossible.

On the other hand, if we set up e2e in the base repo, we should be fine with the dependencies since the CI are run from the main repo but we do need to tune CI testing. If somebody takes #118 some of the obstacles should be cleared out of the way.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[roycaihw]

/remove-lifecycle stale
/lifecycle frozen
/area test

[yliaog]

/cc @roycaihw

[roycaihw]

I think #117 (comment) and #117 (comment) still hold. The problem is in python-base developer UX. Developers should be able to add E2E tests in the same PR as their add new features / fix bugs.

Two naive ways of fixing this:

• just port some e2e tests from the main repo to the base repo and verify if they work. If so, it can be the starting point of adding more e2e tests to python-base
• merge python and python-base into one repo

[mitar]

merge python and python-base into one repo

Yea, I am not sure why these are separate at all. I mean, Python code is generally not used in space-constraint environments, so having base be simply a sub-package of the main Python package is good enough for code reuse (if somebody wants to build a new Python package using code from base). The fact that you would have some extra files around should not bother you.

So, I would propose combining repositories into one Python package, where base becomes a sub-package of the main package with the client.

[roycaihw]

This repo has been merged into the main python repo. We are archiving this repo. Please open a new issue in the main repo. Thanks!

/close

[k8s-ci-robot]

@roycaihw: Closing this issue.

In response to this:

This repo has been merged into the main python repo. We are archiving this repo. Please open a new issue in the main repo. Thanks!

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.