Added FollowLogs class

[borremosch]

Because I was unable to follow the logs of a specific pod as described in #110, I created this helper class based on a combination of readNamespacedPodLog in api.ts and the Watch class in watch.ts.

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: helpdesk@rt.linuxfoundation.org

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: borremosch
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: brendandburns

If they are not already assigned, you can assign the PR to them by writing /assign @brendandburns in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[borremosch]

I have signed the CLA

[brendandburns]

use newer import syntax everywhere.

[brendandburns]

Probably should have stream.on('error', ...)

[brendandburns]

Thanks, this generally looks good, a few small comments.

[drubin]

Can we please make this consistent with the other api methods? namespace, podName, containerName

See
https://github.com/kubernetes-client/javascript/blob/master/src/exec.ts#L34
https://github.com/kubernetes-client/javascript/blob/master/src/attach.ts#L20
This only makes use of pod
https://github.com/kubernetes-client/javascript/blob/master/src/portforward.ts#L25

@brendandburns I would actually be in favour of requiring container name since logs operator on container similar to exec we can always default it to the cluster/config default if undefined.

[brendandburns]

that's fine with me too. consistent api makes sense. thanks for higlighting that.

[brendandburns]

@borremosch I'm going to merge #83 instead of this PR, since it was earlier (and subsumes this functionality) please have a look at that and see if it addresses your needs.

Thanks! (and apologies)

[drubin]

/close

Closing this in favor of #83 which was merged and lack of response.

[k8s-ci-robot]

@drubin: Closed this PR.

In response to this:

/close

Closing this in favor of #83 which was merged and lack of response.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.