Update client to kubernetes 1.8 #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lwander
reviewed
Sep 30, 2017
|
Looks like the URL path stays the same for CoreV1Pods. When a resource is promoted from a beta track to v1, does the API spec keep the beta resource around? |
|
I will look into this. Probably I need to change the pre-processing script to keep the names backward compatible. That would benefit all clients. Will update this PR and ping you when it is ready. Thanks. |
|
@lwander I fixed the client generator in kubernetes-client/gen#24 and updated the client here using the new code to see if it fixed the problem. Please take another look. |
|
Looks good - shame the extra parameters are required for all API calls |
|
I'm ready to merge when you are |
|
The other PR is merged. Please merge this one. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add update client script and update client to kubernetes 1.8.