Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated bazel build rules by migration from WORKSPACE to bzlmod #258

Merged

Conversation

joyanta55
Copy link
Contributor

@joyanta55 joyanta55 commented Dec 19, 2024

PR for #257.

Addresses the issue caused by the Bazel community's decision to fully transition to the bzlmod approach for resolving Bazel dependencies, instead of traditional WORKSPACE approach.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 19, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 19, 2024
@joyanta55 joyanta55 marked this pull request as ready for review December 19, 2024 15:48
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 19, 2024
@joyanta55 joyanta55 closed this Dec 19, 2024
@joyanta55 joyanta55 deleted the joyanta55/bazel-switch-bzlmod branch December 19, 2024 15:51
@joyanta55 joyanta55 restored the joyanta55/bazel-switch-bzlmod branch December 19, 2024 15:55
@joyanta55 joyanta55 reopened this Dec 19, 2024
@ityuhui
Copy link
Member

ityuhui commented Dec 20, 2024

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 20, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ityuhui, joyanta55

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 20, 2024
@k8s-ci-robot k8s-ci-robot merged commit 91b2852 into kubernetes-client:master Dec 20, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants