-
Notifications
You must be signed in to change notification settings - Fork 791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add redirects to GitHub content. #96
Conversation
We want to define pages at kubeflow.org/version/stable that can be updated to point to the latest stable release. We update stable to point at 0.2.2. Note: When downloading deploy.sh you still need to set the environment variable KUBEFLOW_VERSION because we don't set the appropriate version in the deploy script. Fix kubeflow#1156
/assign @pdmack |
Are we documenting this technique outside this PR? |
@pdmack I was going to wait until after #1239 to update the instructions but I guess we could also update the instructions to be
It seemed a little weird to me that you specify two different versions "0.2.2" and "stable". Although I guess we could also create the link 0.2.2 so it would be
I'm a little reluctant though to go down the road of maintaining duplicate URLs to the extent GitHub will already give us URLs corresponding to each version. Thoughts? |
It looks like we can maybe move Git tags. So maybe we should be going that route and not messing with redirects. |
Maybe redirects are better. Force pushing tags might get a little squirrelly. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pdmack The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fix kubeflow/kubeflow#1156
After this PR you could something like
We can then update the version that stable points to as part of our release process.