Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Highlights how write out metrics and results for visualization by the Kubeflow Pipelines UI #722

Merged
merged 6 commits into from
May 29, 2019
Merged

Highlights how write out metrics and results for visualization by the Kubeflow Pipelines UI #722

merged 6 commits into from
May 29, 2019

Conversation

sarahmaddox
Copy link
Contributor

@sarahmaddox sarahmaddox commented May 20, 2019 •
edited by jlewi
Loading

Fixes #575

This change is Reviewable

@k8s-ci-robot k8s-ci-robot requested review from dsdinter and inc0 May 20, 2019 00:14
@sarahmaddox
Copy link
Contributor Author

/uncc @inc0
/uncc @dsdinter

Removing reviewers for now, as this PR will be noisy until I've finished developing the content.

@k8s-ci-robot k8s-ci-robot removed request for inc0 and dsdinter May 20, 2019 00:15
@sarahmaddox
Copy link
Contributor Author

Preview:

@sarahmaddox sarahmaddox changed the title WIP - Highlights how write out metrics and results for visualization by the Kubeflow Pipelines UI Highlights how write out metrics and results for visualization by the Kubeflow Pipelines UI May 20, 2019
@sarahmaddox
Copy link
Contributor Author

This PR is now ready for review. Adding a hold to allow for multiple reviewers.

/hold

@sarahmaddox
Copy link
Contributor Author

/assign @paveldournov

hongye-sun
hongye-sun reviewed May 20, 2019
View reviewed changes
Copy link
Contributor

@hongye-sun hongye-sun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks.

@sarahmaddox
Copy link
Contributor Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the lgtm label May 24, 2019
@sarahmaddox
Copy link
Contributor Author

Thanks @hongye-sun and @rileyjbauer PTAL and LGTM if you're happy with the updates.

rileyjbauer
rileyjbauer reviewed May 28, 2019
View reviewed changes
Copy link
Contributor

@rileyjbauer rileyjbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment but otherwise looks good to me!

@rileyjbauer
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rileyjbauer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit c32a8df into kubeflow:master May 29, 2019
@sarahmaddox sarahmaddox deleted the visualui branch June 5, 2019 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rileyjbauer rileyjbauer rileyjbauer left review comments

@hongye-sun hongye-sun hongye-sun left review comments

@alecglassford alecglassford alecglassford approved these changes

Assignees

@paveldournov paveldournov

@rileyjbauer rileyjbauer

@hongye-sun hongye-sun

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Highlight the Kubeflow Pipelines UI for data and metrics visualization
6 participants
@sarahmaddox @rileyjbauer @k8s-ci-robot @alecglassford @hongye-sun @paveldournov