Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add docs around pipelines obj store configurations #3833

Merged
merged 1 commit into from
Sep 17, 2024
Merged

add docs around pipelines obj store configurations #3833

merged 1 commit into from
Sep 17, 2024

Conversation

HumairAK
Copy link
Contributor

@HumairAK HumairAK commented Aug 1, 2024 •
edited
Loading

@HumairAK
Copy link
Contributor Author

HumairAK commented Aug 1, 2024

/hold

This should not be merged until KFP 2.3 released (no timelines on this yet)

@HumairAK
Copy link
Contributor Author

HumairAK commented Aug 1, 2024

cc @thesuperzapper

@gregsheremeta
Copy link
Contributor

looks good to me! I'll wait to tag it so that others have a chance to provide feedback.

sidebar: the different yamls for all the different ways to setup the various object stores gets confusing really fast, and feels like it would be prone to getting misconfigured easily. I wonder if there could be some way to abstract all of that cruft behind some nice "data connection" facade...

This was referenced Aug 6, 2024
Merged
Open
@HumairAK
Copy link
Contributor Author

with kfp 2.3 out, these docs can be added

it would be good to get some more reviews on this however

/unhold

@HumairAK HumairAK force-pushed the obj-store-configurations branch from 8ba9b3e to 49a8395 Compare September 16, 2024 17:42
@HumairAK HumairAK force-pushed the obj-store-configurations branch from 49a8395 to e19d388 Compare September 16, 2024 19:32
@HumairAK
add docs around pipelines obj store configurations
0063a88 
Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
@HumairAK HumairAK force-pushed the obj-store-configurations branch from e19d388 to 0063a88 Compare September 16, 2024 19:33
@rimolive
Copy link
Member

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Sep 16, 2024
@franciscojavierarceo
Copy link
Contributor

franciscojavierarceo commented Sep 17, 2024 •
edited
Loading

/lgtm

@rimolive
Copy link
Member

/approve

@google-oss-prow Google OSS Prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rimolive

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 76df2f7 into kubeflow:master Sep 17, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rimolive rimolive rimolive left review comments

@anishasthana anishasthana anishasthana left review comments

@VaniHaripriya VaniHaripriya VaniHaripriya left review comments

@connor-mccarthy connor-mccarthy Awaiting requested review from connor-mccarthy

@hbelmiro hbelmiro Awaiting requested review from hbelmiro

Assignees

@rimolive rimolive

Labels
approved lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@HumairAK @gregsheremeta @rimolive @franciscojavierarceo @anishasthana @VaniHaripriya