Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kubeflow 1.6 release page #3332

Merged
merged 3 commits into from
Sep 7, 2022
Merged

Conversation

annajung
Copy link
Member

Signed-off-by: Anna Jung (VMware) antheaj@vmware.com

  • Add 1.6 release page
  • Some links are not available yet

cc @kubeflow/release-team

/hold until docs deadline Aug 31st

Signed-off-by: Anna Jung (VMware) <antheaj@vmware.com>
@annajung
Copy link
Member Author

@zijianjoy
Copy link
Contributor

/lgtm
/approve

Feel free to unhold based on your schedule.

</tr>
</tbody>
</table>
</div>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking: It will be great to have a list of K8S versions we support in this release.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's a great idea! I updated the page to include all dependencies that we tracked for the release. PTAL https://deploy-preview-3332--competent-brattain-de2d6d.netlify.app/docs/releases/kubeflow-1.6/

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you Anna!

Signed-off-by: Anna Jung (VMware) <antheaj@vmware.com>
@google-oss-prow google-oss-prow bot removed the lgtm label Aug 26, 2022
Signed-off-by: Anna Jung (VMware) <antheaj@vmware.com>
@annajung
Copy link
Member Author

@kubeflow/release-team updated to include kustomize into the dependency list - PTAL

@annajung
Copy link
Member Author

Hi everyone, can I get another review (lgtm) for the dependency version table that was added?
aiming to get this merged before the release branch is cut

cc @kubeflow/release-team @zijianjoy

@annajung
Copy link
Member Author

will hold until the 1.6 release day

@zijianjoy
Copy link
Contributor

/lgtm
/approve

Feel free to unhold when the time comes to 1.6 release

@google-oss-prow google-oss-prow bot added the lgtm label Aug 30, 2022
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: annajung, zijianjoy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@annajung
Copy link
Member Author

annajung commented Sep 7, 2022

/hold cancel

@google-oss-prow google-oss-prow bot merged commit 7b22fbc into kubeflow:master Sep 7, 2022
@thesuperzapper
Copy link
Member

@annajung are you sure that we require Kubernetes 1.22 as a minimum (along with the other dependencies listed in the table)? Because right now we are implying that you "must" use the versions of the dependencies listed, which may prevent people from updating to 1.6.0.

I think we can make 3 improvements to that table:

  1. Define a "range" of validated/tested versions for each dependency
  2. Add a link to a page on kubeflow/manifests that describes how versions are tested/validated
  3. Update the language to say "validated/tested dependency versions" rather than "dependency versions"
    • Obviously, we don't yet know if unreleased versions of the dependencies will work fine, so it makes more sense to update that language.

@annajung
Copy link
Member Author

@thesuperzapper the dependency version lists what manifest WG tested with to validate the 1.6 release. It is correct that the Kubeflow release team and manifest cannot recommend any other version to be used other than listed as it was not fully tested with any other version.

My understanding is that manifest group will continue to improve the tests and hope we can define list of range of version, but that was not the case for 1.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants