Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kfp: Update Service account explanation in mult-user access #3037

Merged
merged 5 commits into from
Nov 3, 2021

Conversation

zijianjoy
Copy link
Contributor

Addressing comments in #3022.

Thank you @bartgras and @Bobgy for the information and comments!

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zijianjoy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

@Bobgy Bobgy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold
Feel free to unhold.

@@ -165,6 +166,9 @@ Choose your use-case from one of the options below:
audience: pipelines.kubeflow.org
```

Note that this example uses `default-editor` in `my-namespace` as the service account identity, but you can configure
to use any service account that runs in your Pod.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are probably missing the explanation of what permissions the service account needs.

kubeflow/pipelines#3513 (comment) is best documentation we have for now

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Yuan! Updated documentation for RBAC role binding. I am not sure if I have described it precisely, would you like to take a look? thank you!

@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@zijianjoy zijianjoy requested a review from Bobgy October 22, 2021 00:13
@zijianjoy
Copy link
Contributor Author

/unhold

@zijianjoy zijianjoy added the lgtm label Nov 3, 2021
@google-oss-robot google-oss-robot merged commit 5ed04ec into kubeflow:master Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants