Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[KFP] Introduce inline visualization #1766

Merged
merged 6 commits into from
Mar 9, 2020
Merged

[KFP] Introduce inline visualization #1766

merged 6 commits into from
Mar 9, 2020

Conversation

Bobgy
Copy link
Contributor

@Bobgy Bobgy commented Mar 3, 2020 •
edited by jlewi
Loading

/assign @joeliedtke

Documentation for kubeflow/pipelines#3177

This change is Reviewable

@joeliedtke
Copy link
Member

This change can be previewed at:
https://deploy-preview-1766--competent-brattain-de2d6d.netlify.com/docs/pipelines/sdk/output-viewer/

joeliedtke
joeliedtke reviewed Mar 4, 2020
View reviewed changes
Copy link
Member

@joeliedtke joeliedtke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding these changes. I added a few comments and suggestions.

Bobgy
Bobgy commented Mar 4, 2020
View reviewed changes
Copy link
Contributor Author

@Bobgy Bobgy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @joeliedtke! Thanks for your valuable suggestions!
I've updated accordingly. Please take a look again when you have time.

joeliedtke
joeliedtke reviewed Mar 5, 2020
View reviewed changes
Copy link
Member

@joeliedtke joeliedtke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a couple suggestions.

@Bobgy
Copy link
Contributor Author

Bobgy commented Mar 5, 2020

Hi @joeliedtke, FYI, github has a feature to let you provide a suggestion that I can apply with a simple mouse click. It would be a good choice for wording changes.
Screen Shot 2020-03-05 at 9 45 35 AM

@Bobgy
Copy link
Contributor Author

Bobgy commented Mar 5, 2020

@joeliedtke Thanks! Updated again

@Bobgy
Copy link
Contributor Author

Bobgy commented Mar 6, 2020

@joeliedtke Is this ready to be approved?

@Bobgy Bobgy mentioned this pull request Mar 6, 2020
Closed
@Bobgy
Copy link
Contributor Author

Bobgy commented Mar 6, 2020

Fixes kubeflow/pipelines#3133

@joeliedtke
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joeliedtke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit c76ec73 into kubeflow:master Mar 9, 2020
@Bobgy Bobgy deleted the kfp_inline_vis branch March 10, 2020 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joeliedtke joeliedtke joeliedtke left review comments

@abhi-g abhi-g Awaiting requested review from abhi-g

@gaoning777 gaoning777 Awaiting requested review from gaoning777

Assignees

@joeliedtke joeliedtke

Labels
approved lgtm size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Bobgy @joeliedtke @k8s-ci-robot