-
Notifications
You must be signed in to change notification settings - Fork 724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: the "follow" of TFJobClient.get_logs #1254
Conversation
Hi @Windfarer. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/assign @jinchihe
/ok-to-test |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jinchihe, terrytangyuan, Windfarer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
IMO, the
follow
parameter ofTFJobClient.get_logs
method should continually fetch and print the log stream of every listening pods. But the actual behavior is we can only get the log after pod's execution is finished.As the discussion of this kubernetes-client/python#199 the correct way to get the stream is to call
read_namespaced_pod_log
withwatch.Watch
.This PR is an approach to fix this issue.
The output of
watch.stream
is a generator, so we could iterate over every pods's stream, group log lines and print them.