Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: the "follow" of TFJobClient.get_logs #1254

Merged
merged 2 commits into from
Apr 15, 2021

Conversation

Windfarer
Copy link
Contributor

@Windfarer Windfarer commented Mar 17, 2021

IMO, the follow parameter of TFJobClient.get_logs method should continually fetch and print the log stream of every listening pods. But the actual behavior is we can only get the log after pod's execution is finished.

As the discussion of this kubernetes-client/python#199 the correct way to get the stream is to call read_namespaced_pod_log with watch.Watch.

This PR is an approach to fix this issue.

The output of watch.stream is a generator, so we could iterate over every pods's stream, group log lines and print them.

@aws-kf-ci-bot
Copy link
Contributor

Hi @Windfarer. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 71.479% when pulling d957a6f on Windfarer:watch_log into cadfd91 on kubeflow:master.

Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/assign @jinchihe

@gaocegege
Copy link
Member

/ok-to-test

@jinchihe
Copy link
Member

/lgtm
/approve

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jinchihe, terrytangyuan, Windfarer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit 58c9bc4 into kubeflow:master Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants