Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Pytorch with PyTorch #1874

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

tenzen-y
Copy link
Member

@tenzen-y tenzen-y commented Aug 1, 2023

What this PR does / why we need it:
I replaced Pytoch with PyTorch.

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Fixes #

Checklist:

  • Docs included if any changes are user facing

@coveralls
Copy link

coveralls commented Aug 1, 2023

Pull Request Test Coverage Report for Build 5730657897

  • 17 of 34 (50.0%) changed or added relevant lines in 8 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.02%) to 40.336%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/controller.v1/register_controller.go 0 1 0.0%
pkg/controller.v1/pytorch/pytorchjob_controller.go 10 17 58.82%
pkg/apis/kubeflow.org/v1/pytorch_defaults.go 0 9 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/apis/kubeflow.org/v1/pytorch_defaults.go 2 39.62%
pkg/controller.v1/mpi/mpijob_controller.go 2 80.12%
Totals Coverage Status
Change from base Build 5728469832: -0.02%
Covered Lines: 3861
Relevant Lines: 9572

💛 - Coveralls

Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
@tenzen-y tenzen-y force-pushed the pytorch-is-PyTorch branch from f17a585 to 66bd9bd Compare August 1, 2023 18:45
// PyTorchJobSingular is the singular for pytorchJob.
PyTorchJobSingular = "pytorchjob"
// PyTorchJobFrameworkName is the name of the ML Framework
PyTorchJobFrameworkName = "pytorch"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this have to be "PyTorch" too?

Copy link
Member Author

@tenzen-y tenzen-y Aug 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@terrytangyuan
Copy link
Member

/lgtm

@tenzen-y
Copy link
Member Author

tenzen-y commented Aug 1, 2023

@terrytangyuan Thank you for the review!
Could you add an /approve label and restart https://github.com/kubeflow/training-operator/actions/runs/5730657897/job/15529894448?pr=1874?

@terrytangyuan
Copy link
Member

/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tenzen-y, terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@terrytangyuan
Copy link
Member

We could consider adding retries to failed builds.

@google-oss-prow google-oss-prow bot merged commit e208389 into kubeflow:master Aug 1, 2023
@tenzen-y
Copy link
Member Author

tenzen-y commented Aug 1, 2023

We could consider adding retries to failed builds.

Instead of automatically retrying, Introducing ChatOps to retry jobs manually might be better for finding the flakiness.

@tenzen-y tenzen-y deleted the pytorch-is-PyTorch branch August 1, 2023 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants