-
Notifications
You must be signed in to change notification settings - Fork 741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Pytorch with PyTorch #1874
Conversation
Pull Request Test Coverage Report for Build 5730657897
💛 - Coveralls |
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
f17a585
to
66bd9bd
Compare
// PyTorchJobSingular is the singular for pytorchJob. | ||
PyTorchJobSingular = "pytorchjob" | ||
// PyTorchJobFrameworkName is the name of the ML Framework | ||
PyTorchJobFrameworkName = "pytorch" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this have to be "PyTorch" too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@terrytangyuan I think that we need not change both values since the singular is defined as a lowercase in general, and all framework names are defined as a lower case such as tensorflow
:
CRD doc: https://kubernetes.io/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definitions/
/lgtm |
@terrytangyuan Thank you for the review! |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tenzen-y, terrytangyuan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
We could consider adding retries to failed builds. |
Instead of automatically retrying, Introducing ChatOps to retry jobs manually might be better for finding the flakiness. |
What this PR does / why we need it:
I replaced
Pytoch
withPyTorch
.Which issue(s) this PR fixes (optional, in
Fixes #<issue number>, #<issue number>, ...
format, will close the issue(s) when PR gets merged):Fixes #
Checklist: