Remove duplicated imports for pkg/apis/kubeflow.org/v1 #1847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cefdbf9 to
6baf6e3
Compare
tenzen-y
commented
Jul 4, 2023
| kubeflowv1 "github.com/kubeflow/training-operator/pkg/apis/kubeflow.org/v1" | ||
| trainingoperatorcommon "github.com/kubeflow/training-operator/pkg/common" | ||
| "github.com/kubeflow/training-operator/pkg/common/util" | ||
| "github.com/kubeflow/training-operator/pkg/controller.v1/common" | ||
| "github.com/kubeflow/training-operator/pkg/controller.v1/control" | ||
| "github.com/kubeflow/training-operator/pkg/controller.v1/expectation" | ||
| commonutil "github.com/kubeflow/training-operator/pkg/util" | ||
| train_util "github.com/kubeflow/training-operator/pkg/util/train" | ||
| trainutil "github.com/kubeflow/training-operator/pkg/util/train" |
There was a problem hiding this comment.
We shouldn't use snake case for Golang.
Pull Request Test Coverage Report for Build 5451231793
💛 - Coveralls |
6baf6e3 to
937071e
Compare
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
937071e to
bb3c660
Compare
tenzen-y
commented
Jul 4, 2023
| @@ -89,25 +88,24 @@ const ( | |||
| ) | |||
|
|
|||
| // initializeMPIJobStatuses initializes the ReplicaStatuses for MPIJob. | |||
| func initializeMPIJobStatuses(mpiJob *kubeflowv1.MPIJob, mtype commonv1.ReplicaType) { | |||
| replicaType := commonv1.ReplicaType(mtype) | |||
There was a problem hiding this comment.
This is redundant type casting.
|
|
|
/assign @johnugeorge @terrytangyuan |
|
Thanks @tenzen-y |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johnugeorge, tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
I removed duplicated imports for "github.com/kubeflow/training-operator/pkg/apis/kubeflow.org/v1".
commonv1vskubeflowv1.Also, I removed redundant type casting for
kubeflowv1.ReplicaType.Which issue(s) this PR fixes (optional, in
Fixes #<issue number>, #<issue number>, ...format, will close the issue(s) when PR gets merged):Fixes #1816
Checklist: