cleanup_ci needs to use different expiration times for auto deployed and E2E clusters #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and E2E clusters * The auto deployed clusters are now using unique names rather than being recycled and we rely on cleanup_ci.py to GC old auto-deployments (kubeflow#444) * To support this we need to use variable expiration times. * Deployments created by tests should expire as soon as the test is done (so 1-2 hours) * But auto-deployed clusters need to live longer * There are only refreshed periodically by a cron job (~8 hours) we don't want to delete the cluster before a new one is deployed because we need a cluster for the example tests * We want to leave the clusters up as long as we can to facilitate debugging by people working on example tests. Related to kubeflow#444
|
/assign @zhenghuiwang |
zhenghuiwang
reviewed
Nov 1, 2019
py/kubeflow/testing/cleanup_ci.py
Outdated
| @@ -694,7 +739,7 @@ def cleanup_service_accounts(args): | |||
| now = datetime.datetime.now(valid_time.tzinfo) | |||
|
|
|||
| age = now - valid_time | |||
| if age < datetime.timedelta(hours=args.max_age_hours): | |||
| if age < MAX_LIFETIME[a["email"]]: | |||
There was a problem hiding this comment.
Do you want to use infra_type instead of a["email"]?
py/kubeflow/testing/cleanup_ci.py
Outdated
| @@ -1015,17 +1068,6 @@ def main(): | |||
| help=("""Whether to GC backend services that are older | |||
There was a problem hiding this comment.
The comment on this flag needs some change since it relates to --max_ci_deployment_resource_age_hours
|
Thanks @zhenghuiwang PTAL |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zhenghuiwang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The auto deployed clusters are now using unique names rather than being
recycled and we rely on cleanup_ci.py to GC old auto-deployments (Auto-deployments of Kubeflow should use unique names and not recycle names - Upgrade to v0.7 #444)
To support this we need to use variable expiration times.
Deployments created by tests should expire as soon as the test is done (so 1-2 hours)
But auto-deployed clusters need to live longer
There are only refreshed periodically by a cron job (~8 hours) we don't
want to delete the cluster before a new one is deployed because we need
a cluster for the example tests
We want to leave the clusters up as long as we can to facilitate debugging
by people working on example tests.
Related to #444
This change is