Auto deploy job needs to use the new kfctl syntax. #495
Conversation
26cefc2 to
bc78726
Compare
py/kubeflow/testing/cleanup_ci.py
Outdated
| # See https://github.com/kubeflow/testing/issues/444 | ||
| # We are switching to unique names for auto deployments | ||
| # So this matches the new ones. | ||
| AUTO_DEPLOY_PATTERN = re.compile("kf-vmaster-(?!n\d\d)") |
There was a problem hiding this comment.
this only matches auto-deployment from master? how about current stable release?
There was a problem hiding this comment.
This is deliberate. The existing auto deployed clusters aren't cleaned up by cleanup_ci.py. Instead the auto deployment script recycles clusters as it cycles through names.
Related to kubeflow#471 * Don't set name in the spec because we want to infer it form directory. * Create a new script to deploy with a unique name * Related to: kubeflow#444 * Update cleanup script to clean up new auto-deployed clusters
fbeac4f to
5ce9084
Compare
…sters because otherwise we hit lets-encrypt rate limiting.
|
I verified this worked. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlewi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Auto deploy job needs to use the new kfctl syntax; also use unique names
Related to #471
Don't set name in the spec because we want to infer it form directory.
Create a new script to deploy with a unique name
Related to: Auto-deployments of Kubeflow should use unique names and not recycle names - Upgrade to v0.7 #444
Update cleanup script to clean up new auto-deployed clusters
This change is