Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert "Support subdirectories for junit files and grouping in test grid by name (#490)" (#493)" #494

Merged
merged 1 commit into from
Oct 18, 2019

Conversation

jlewi
Copy link
Contributor

@jlewi jlewi commented Oct 18, 2019

This reverts commit 81326be.

  • Relates to Support grouping in testgrid #489 - group results in test grid

  • Roll forward the orginal change now that kfctl_create_e2e_workflow.py
    has been updated to handle the extra argument.

    • add a leading / to test names; this should hopefully remove an unnecessary grouping layer when
      grouping by hierarchy in test grid.

This change is Reviewable

…n test grid by name (kubeflow#490)" (kubeflow#493)"

This reverts commit 81326be.

* Relates to kubeflow#489

* Roll forward the orginal change now that kfctl_create_e2e_workflow.py
  has been updated to handle the extra argument.

add a leading /
@jlewi
Copy link
Contributor Author

jlewi commented Oct 18, 2019

/assign @lluunn

@lluunn
Copy link
Contributor

lluunn commented Oct 18, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lluunn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit f8302c8 into kubeflow:master Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants