Modify run_e2etest script to check for job_types and include_dirs #180
Conversation
|
/uncc @jlewi |
|
/assign @jlewi |
|
This looks great. Can you update README.md to provide instructions on how to scope tests? In particular can you include a snippet of what the update YAML looks like? |
|
Done. |
README.md
Outdated
| component: workflows | ||
| name: unittests | ||
| job_types: presubmit | ||
| include_dirs: foo/*,bar/* |
There was a problem hiding this comment.
job_types and include_dirs should be arrays of strings e.g.
include_dirs:
- foo/*
- bar/*
| @@ -72,8 +75,15 @@ def parse_config_file(config_file, root_dir): | |||
|
|
|||
| components = [] | |||
| for i in results["workflows"]: | |||
| job_types = [] | |||
| if i.get("job_types"): | |||
| job_types = i.get("job_types").split(",") | |||
There was a problem hiding this comment.
job_types and include_dirs should be arrays.
| @@ -105,7 +120,7 @@ def run(args, file_handler): # pylint: disable=too-many-statements,too-many-bran | |||
|
|
|||
| if args.app_dir and args.component: | |||
| # TODO(jlewi): We can get rid of this branch once all repos are using a prow_config.xml file. | |||
| workflows.append(WorkflowComponent("legacy", args.app_dir, args.component, {})) | |||
| workflows.append(WorkflowComponent("legacy", args.app_dir, args.component, [], [], {})) | |||
There was a problem hiding this comment.
I think it should be safe to delete this now. We could also do this in a separate PR either before or after this PR. In the event we do have some tests not updated breaking them is one of the quickest ways to find them.
|
Done. I also removed testMainPresubmit since it no longer applies. |
|
This is fantastic. /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlewi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Related to #150 run E2E tests selectively based on modified source files.
Related to #168 project velocity negatively impacted by test flakiness.
This change is