Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add proxy agent image to cloud builder #996

Merged
merged 1 commit into from
Mar 30, 2019
Merged

add proxy agent image to cloud builder #996

merged 1 commit into from
Mar 30, 2019

Conversation

IronPan
Copy link
Member

@IronPan IronPan commented Mar 19, 2019

/assign @hongye-sun

This can be checked in after #988 is merged
/hold


This change is Reviewable

@IronPan
Copy link
Member Author

IronPan commented Mar 19, 2019

/hold

Copy link
Contributor

@hongye-sun hongye-sun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@IronPan
Copy link
Member Author

IronPan commented Mar 20, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vicaire vicaire removed their request for review March 21, 2019 00:17
@jlewi jlewi removed their request for review March 23, 2019 22:27
@IronPan
Copy link
Member Author

IronPan commented Mar 29, 2019

/hold cancel

@IronPan
Copy link
Member Author

IronPan commented Mar 30, 2019

/test kubeflow-pipeline-e2e-test

@IronPan
Copy link
Member Author

IronPan commented Mar 30, 2019

/test kubeflow-pipeline-e2e-test

@k8s-ci-robot k8s-ci-robot merged commit 3911305 into master Mar 30, 2019
@IronPan IronPan deleted the image branch May 30, 2019 07:16
Linchin added a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this pull request Mar 11, 2024
…and step-copy-artifacts. Fixes kubeflow#996 (kubeflow#997)

* Added support to directories in step-copy-results-artifacts script

Check if the provided result (src) is a directory; if so, create a tar.gz archive and compute the ARTIFACT_SIZE on {src}.tar.gz.
Moreover, print on {dst} file the list of files in {src}.tar.gz (namely, the result of `tar -tzf {src}.tar.gz`) instead of copying directly {src} into {dst}

* Add support to directories in step-copy-artifacts script

Added check [ -d "$2" ] to allow directories to be transmitted as artifacts

* Update unit tests

* Update sdk/python/kfp_tekton/compiler/_data_passing_rewriter.py

Co-authored-by: Tommy Li <Tommy.chaoping.li@ibm.com>

* reducing script size

* generated tests

* removed whitespace identified by lint test

* fixed error (missing suffix)

* generated tests

Co-authored-by: Tommy Li <Tommy.chaoping.li@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants