-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add proxy agent image to cloud builder #996
Conversation
/hold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: IronPan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: IronPan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
/test kubeflow-pipeline-e2e-test |
/test kubeflow-pipeline-e2e-test |
…and step-copy-artifacts. Fixes kubeflow#996 (kubeflow#997) * Added support to directories in step-copy-results-artifacts script Check if the provided result (src) is a directory; if so, create a tar.gz archive and compute the ARTIFACT_SIZE on {src}.tar.gz. Moreover, print on {dst} file the list of files in {src}.tar.gz (namely, the result of `tar -tzf {src}.tar.gz`) instead of copying directly {src} into {dst} * Add support to directories in step-copy-artifacts script Added check [ -d "$2" ] to allow directories to be transmitted as artifacts * Update unit tests * Update sdk/python/kfp_tekton/compiler/_data_passing_rewriter.py Co-authored-by: Tommy Li <Tommy.chaoping.li@ibm.com> * reducing script size * generated tests * removed whitespace identified by lint test * fixed error (missing suffix) * generated tests Co-authored-by: Tommy Li <Tommy.chaoping.li@ibm.com>
/assign @hongye-sun
This can be checked in after #988 is merged
/hold
This change is