Minor fix on samples/tfx-oss/README.md

[ucdmkt]

• TFX whl doesn't seem to install TensorFlow
• Remove ! at the beginning (copy'n'pasted from notebook?)
• There is no longer taxi_pipelien_kubeflow_large.py in https://github.com/tensorflow/tfx/tree/master/examples/chicago_taxi_pipeline

---

This change is 

[k8s-ci-robot]

Hi @ucdmkt. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

Hi @ucdmkt. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Ark-kun]

/ok-to-test

[neuromage]

Thanks for the fix

/ok-to-test
/lgtm

[neuromage]

/hold

Hmm, looks like these changes aren't based on master. I think some of this has already been fixed. Requiring TF 1.12 is a change worth making though. Can you sync and try again? Thanks.

[Ark-kun]

BTW, does TFX on Kubeflow requires TF to be installed? Sure, the components use it, but is it needed on the client machine?

[ucdmkt]

Without TF installed on client machine, graph compilation failed in my environment.

[Ark-kun]

Without TF installed on client machine, graph compilation failed in my environment.

You should probably also create an issue in https://github.com/tensorflow/tfx .

[neuromage]

Without TF installed on client machine, graph compilation failed in my environment.

You should probably also create an issue in https://github.com/tensorflow/tfx .

I don't think that's needed. This seems to be about instructions for running it with KFP, which belong here.

[vicaire]

@ucdmkt, is this PR still needed? Can we close?

[ucdmkt]

@vicaire I think it is still relevant for the first two bullet points?

[Ark-kun]

I don't think that's needed. This seems to be about instructions for running it with KFP, which belong here.

I do not see any usage of raw TF in the TFX Kubeflow sample:
https://github.com/tensorflow/tfx/blob/master/tfx/examples/chicago_taxi_pipeline/taxi_pipeline_kubeflow.py

Is it the case that TFX requires TF, but does not install it when installed using the wheel?

[ucdmkt]

Is it the case that TFX requires TF, but does not install it when installed using the wheel?

Indeed. TFX whl doesn't come with TF. And, TFX documentation instructs users to separately pip install TensorFlow.

(also; updated path to example code according to latest tensorflow/tfx)

$ python tfx/tfx/examples/chicago_taxi_pipeline/taxi_pipeline_kubeflow.py
Traceback (most recent call last):
  File "tfx/tfx/examples/chicago_taxi_pipeline/taxi_pipeline_kubeflow.py", line 21, in <module>
    from tfx.components.evaluator.component import Evaluator
  File "/usr/local/google/home/muchida/miniconda3/envs/tfx-kfp-2/lib/python3.5/site-packages/tfx/components/evaluator/component.py", line 23, in <module>
    from tfx.components.base import base_driver
  File "/usr/local/google/home/muchida/miniconda3/envs/tfx-kfp-2/lib/python3.5/site-packages/tfx/components/base/base_driver.py", line 20, in <module>
    import tensorflow as tf
ImportError: No module named 'tensorflow'

[neuromage]

/lgtm
/approve

Thanks for fixing this!

[neuromage]

/hold cancel

[neuromage]

@vicaire @IronPan @Ark-kun can one of you please approve? Thanks.

[Ark-kun]

Indeed. TFX whl doesn't come with TF. And, TFX documentation instructs users to separately pip install TensorFlow.

I see. That's rather inconvenient.

[Ark-kun]

@vicaire @IronPan @Ark-kun can one of you please approve? Thanks.

Sure
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun, neuromage

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• samples/OWNERS [Ark-kun]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun, neuromage

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• samples/OWNERS [Ark-kun]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment