Add type check samples #955
Conversation
remove schema validators for GCRPath, and adjust for GCRPath, GCSPath change _check_valid_dict to _check_valid_type_dict to avoid confusion fix typo in the comments adjust function order for readability
update the _check_valid_type_dict name
|
It seems to me that this PR contains 3 separate changes:
It might be best to split out the first two so that they're do not get lost. It's also convenient when compiling release changes. |
|
It is only the bottom two change: turning type checking on by default and adding notebook with DSL type checking sample. |
add more comments within the code block add documentation about the type definition in both yaml and decorated components.
|
/lgtm |
|
/test kubeflow-pipeline-sample-test |
|
/test kubeflow-pipeline-sample-test |
3 similar comments
|
/test kubeflow-pipeline-sample-test |
|
/test kubeflow-pipeline-sample-test |
|
/test kubeflow-pipeline-sample-test |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gaoning777 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubeflow#955) * add pipelinerun pod template support for security context and automount_service_account_token * update flag to the correct type * update flag to the correct type * update flag to the correct type * update usage docs
This change is