Detecting file format using signature instead of file extension #919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
a02945d to
cf7b839
Compare
cf7b839 to
ed0ec7d
Compare
IronPan
reviewed
Mar 7, 2019
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: IronPan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test kubeflow-pipeline-e2e-test |
cheyang
pushed a commit
to alibaba/pipelines
that referenced
this pull request
Mar 28, 2019
…flow#919) * Detecting file format using signature instead of file extension * Added tests for extension-independent pipeline loading * Added another malformed zip test
HumairAK
pushed a commit
to red-hat-data-services/data-science-pipelines
that referenced
this pull request
Mar 11, 2024
* map sanitization logic to original kfp * update test data to reproduce sanitization bug * fix upstream dsl bugs on undeterministic params on long names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the backend detects the pipeline payload type by looking at the file extension.
If we merge the #855 PR, the DSL compiler will start produce files in ZIP format, but unless the pipeline author changes the code (which they realistically won't do), the file name and extension will remain the same:
.tar.gz. This will cause the backend to stop accepting those compiled pipelines which will frustrate our users.This PR replaces format checks based on file name with checks based on file signatures. This fixes the backwards compatibility problem.
This change is