Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add online prediction instructions and print friendly msg in console. #914

Merged
merged 1 commit into from
Mar 5, 2019
Merged

Add online prediction instructions and print friendly msg in console. #914

merged 1 commit into from
Mar 5, 2019

Conversation

hongye-sun
Copy link
Contributor

@hongye-sun hongye-sun commented Mar 5, 2019 •
edited by jlewi
Loading

This change is Reviewable

@gaoning777
Copy link
Contributor

/lgtm

@hongye-sun
Copy link
Contributor Author

/lgtm

@k8s-ci-robot
Copy link
Contributor

@hongye-sun: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@k8s-ci-robot
Copy link
Contributor

@hongye-sun: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hongye-sun
Copy link
Contributor Author

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongye-sun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongye-sun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hongye-sun hongye-sun merged commit 4e936f3 into kubeflow:master Mar 5, 2019
cheyang pushed a commit to alibaba/pipelines that referenced this pull request Mar 28, 2019
@hongye-sun
Add online prediction instructions and print friendly msg in console. (…
079a1fa 
…kubeflow#914)
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
@capri-xiyue
test(kfp): change access permission for kf-ci-v1-prow@kubeflow-ci.iam…
5ffe313 
….gserviceaccount.com (kubeflow#914)

* updated endpoint back to staging

* changed prow account permission back to service account user role of the spefici service account
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
@Iamlovingit
remove the unstable check (kubeflow#914)
b2cd8d0 
remove the unstable check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ark-kun Ark-kun Awaiting requested review from Ark-kun

@gaoning777 gaoning777 Awaiting requested review from gaoning777

Assignees

@gaoning777 gaoning777

Labels
approved lgtm size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hongye-sun @gaoning777 @k8s-ci-robot