Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bug in the gcp oob #861

Merged
merged 1 commit into from
Feb 26, 2019
Merged

fix bug in the gcp oob #861

merged 1 commit into from
Feb 26, 2019

Conversation

gaoning777
Copy link
Contributor

@gaoning777 gaoning777 commented Feb 26, 2019 •
edited by jlewi
Loading

This change is Reviewable

@k8s-ci-robot k8s-ci-robot requested a review from vicaire February 26, 2019 02:06
@gaoning777
Copy link
Contributor Author

More to fix for the GCP OOB build besides: #860

@gaoning777 gaoning777 requested review from IronPan and removed request for IronPan, vicaire and Ark-kun February 26, 2019 02:07
@gaoning777 gaoning777 mentioned this pull request Feb 26, 2019
Merged
@hongye-sun
Copy link
Contributor

/lgtm

@IronPan
Copy link
Member

IronPan commented Feb 26, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 7775692 into kubeflow:master Feb 26, 2019
@hongye-sun
Copy link
Contributor

Thanks for the fix, Ning.

@gaoning777 gaoning777 deleted the gcp-build-failure branch February 26, 2019 21:29
cheyang pushed a commit to alibaba/pipelines that referenced this pull request Mar 28, 2019
@gaoning777 @k8s-ci-robot
fix bug in the gcp oob (kubeflow#861)
4bfe40a
@snyk-bot snyk-bot mentioned this pull request May 26, 2021
Open
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
@yuzisun
Update KFServing roadmap for Q3/Q4 (kubeflow#861)
efd1de5 
* Update KFServing roadmap for Q3/Q4

* Address comments

* move gRPC support to 0.5
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this pull request Mar 11, 2024
@ScrapCodes
feat(pipelineloop): Add caching configuration support through config-…
50eb94a 
…map. (kubeflow#861)

* caching flags

* fix tests

* fix the broken link for kustomize.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rileyjbauer rileyjbauer Awaiting requested review from rileyjbauer

@hongye-sun hongye-sun Awaiting requested review from hongye-sun

@IronPan IronPan Awaiting requested review from IronPan

Assignees

@IronPan IronPan

@vicaire vicaire

@hongye-sun hongye-sun

Labels
approved lgtm size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gaoning777 @hongye-sun @IronPan @k8s-ci-robot @vicaire