Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase disk size and use high CPU machine type in cloud build #813

Merged
merged 1 commit into from
Feb 12, 2019

Conversation

hongye-sun
Copy link
Contributor

@hongye-sun hongye-sun commented Feb 12, 2019

This change is Reviewable

@@ -180,3 +180,4 @@ webencodings,https://raw.githubusercontent.com/gsnedders/python-webencodings/mas
google-api-core,https://raw.githubusercontent.com/googleapis/google-cloud-python/master/LICENSE,Apache 2.0
google-resumable-media,https://raw.githubusercontent.com/googleapis/google-resumable-media-python/master/LICENSE,Apache 2.0
trainer,https://raw.githubusercontent.com/kubeflow/pipelines/master/LICENSE,Apache 2.0
pyarrow,https://raw.githubusercontent.com/apache/arrow/master/LICENSE.txt,Apache 2.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this still needed for this PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I though it was added in my last PR. Not sure why it's not merged in master.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dropped the change in the PR.

@IronPan
Copy link
Member

IronPan commented Feb 12, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hongye-sun
Copy link
Contributor Author

/test kubeflow-pipeline-e2e-test

@IronPan
Copy link
Member

IronPan commented Feb 12, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit 5df2cdc into kubeflow:master Feb 12, 2019
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
…sing (kubeflow#813)

* feat: dockerfile for cleanup cli tool

* cleanup

* add cronjob

* fix
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this pull request Mar 11, 2024
* update pipelineloop and manifests with k8s 1.22 API

* remove preserveUnknownFields since it already enabled by default
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants