-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(frontend): Fix run comparison filter #7833
fix(frontend): Fix run comparison filter #7833
Conversation
/assign @jlyaoyuli |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Thank you Chris for fixing the filtering issue on Compare page! Approving this PR assuming the presubmit passes.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zijianjoy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description of your changes:
RunList.tsx
works correctly in all casesScreen Recording:
This screencast shows both the "Runs" tab and the Run Comparison page working correctly (though only the latter needed a fix).
RunComparisonFilterFixed.mp4
Notes:
listRuns
API, but since that method does not have support for therunIdListMask
, when a mask exists each run is fetched individually (see the_loadRuns
method). This individual fetching of runs did not have a filtering mechanism, and I added that in this PR.filterSubstring
withinRunList.tsx
to detect and apply this filter. However, if more filter options are added in the future, we will likely want to separate this filter logic out.Checklist: