Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): Fix run comparison filter #7833

Merged
merged 5 commits into from
Jun 6, 2022
Merged

fix(frontend): Fix run comparison filter #7833

merged 5 commits into from
Jun 6, 2022

Conversation

zpChris
Copy link
Contributor

@zpChris zpChris commented Jun 3, 2022

Description of your changes:

  1. Add filter functionality for run lists with a run ID list mask
  2. Add tests to verify that the filter mechanism for RunList.tsx works correctly in all cases

Screen Recording:

This screencast shows both the "Runs" tab and the Run Comparison page working correctly (though only the latter needed a fix).

RunComparisonFilterFixed.mp4

Notes:

  • This issue occurred because the filtering mechanism typically occurs through the listRuns API, but since that method does not have support for the runIdListMask, when a mask exists each run is fetched individually (see the _loadRuns method). This individual fetching of runs did not have a filtering mechanism, and I added that in this PR.
  • Currently, only the "name substring" filtering is supported, so I have hard-coded the filterSubstring within RunList.tsx to detect and apply this filter. However, if more filter options are added in the future, we will likely want to separate this filter logic out.

Checklist:

@zpChris zpChris changed the title Fix run comparison filter fix(frontend): Fix run comparison filter Jun 3, 2022
@zpChris zpChris requested a review from zijianjoy June 3, 2022 18:16
@zpChris
Copy link
Contributor Author

zpChris commented Jun 3, 2022

/assign @jlyaoyuli

frontend/src/pages/RunList.tsx Outdated Show resolved Hide resolved
frontend/src/pages/RunList.tsx Outdated Show resolved Hide resolved
Copy link
Collaborator

@zijianjoy zijianjoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thank you Chris for fixing the filtering issue on Compare page! Approving this PR assuming the presubmit passes.

frontend/src/pages/RunList.test.tsx Show resolved Hide resolved
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zijianjoy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit f41b545 into kubeflow:master Jun 6, 2022
@zpChris zpChris deleted the fix-run-comparison-filter branch June 6, 2022 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[frontend] Run Comparison filter mechanism broken
3 participants