Updates frontend to Typescript to 3.3.1 #772
Conversation
7722634 to
280831c
Compare
| afterEach(async () => { | ||
| // unmount() should be called before resetAllMocks() in case any part of the unmount life cycle | ||
| // depends on mocks/spies | ||
| if (tree) { |
There was a problem hiding this comment.
You don't need the check. I don't think anything happens if the tree is unmounted.
There was a problem hiding this comment.
It seems like the await probably isn't needed. We do it in many other tests though. I'll go through and clean that up
280831c to
f80b719
Compare
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
/test kubeflow-pipeline-sample-test |
15ba7ab to
627f7c0
Compare
…mRenderer to make better use of FunctionComponent typings
627f7c0 to
b00f0b5
Compare
|
/test kubeflow-pipeline-sample-test |
|
/test kubeflow-pipeline-e2e-test |
|
@rileyjbauer: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yebrahim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Also updates code around
CustomTable customRendererto make better use ofFunctionComponenttypings.This change is