Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance deploy.sh to support local storage #755

Merged
merged 1 commit into from
Feb 4, 2019
Merged

Enhance deploy.sh to support local storage #755

merged 1 commit into from
Feb 4, 2019

Conversation

jinchihe
Copy link
Member

@jinchihe jinchihe commented Jan 31, 2019 •
edited by jlewi
Loading

fixes: #726

This change is Reviewable

@jinchihe jinchihe mentioned this pull request Jan 31, 2019
Closed
@jinchihe
Copy link
Member Author

/assign @IronPan

To more clear, I closed the old PR #727 which is related the issue #726 . Please review this one. You can check the previous reviewing process in #727 if needed. Thanks a lot.

@gyliu513
Copy link
Member

/lgtm

@gaoning777 gaoning777 self-assigned this Feb 1, 2019
@gaoning777
Copy link
Contributor

Thanks for your contribution @jinchihe and sorry for the PR review delay.

@jinchihe jinchihe force-pushed the support_local_deploy branch from 5dfed00 to f4179cd Compare February 2, 2019 03:38
@gyliu513
Copy link
Member

gyliu513 commented Feb 2, 2019

/lgtm

@jinchihe
Copy link
Member Author

jinchihe commented Feb 2, 2019

Thanks for your contribution @jinchihe and sorry for the PR review delay.

Never mind, your comment has been addressed. Please review. Thanks.

@gaoning777
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaoning777

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaoning777

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gaoning777
Copy link
Contributor

/retest

@k8s-ci-robot k8s-ci-robot merged commit a8164a0 into kubeflow:master Feb 4, 2019
@jinchihe jinchihe deleted the support_local_deploy branch February 5, 2019 09:15
@jinchihe jinchihe mentioned this pull request Feb 15, 2019
Merged
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
AWS Init Support for Kuberflow/Testing (kubeflow#755)
db508d7 
* Add init support for AWS Kubeflow Tests

* Clean up GCP resources in AWS Dockerfile

* Add AWS-CREDENTIALS ENV Support

* Clean Up Resources

* Make Params / Envs Configurable

* Code Clean-up

* Remove redundant args and make as ENVS

* Address PlaceHold Functions for AWS

* Put AWS Python Files in seperate folder

* Add OWNERS files for AWS assets

* Remove added OWNERS

* Clean up

* Clean up

* Clean up aws_util functions
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
@dependabot
Bump bleach in /docs/samples/custom/kfserving-custom-model (kubeflow#755
64f6322 
)

Bumps [bleach](https://github.com/mozilla/bleach) from 3.1.1 to 3.1.4.
- [Release notes](https://github.com/mozilla/bleach/releases)
- [Changelog](https://github.com/mozilla/bleach/blob/master/CHANGES)
- [Commits](mozilla/bleach@v3.1.1...v3.1.4)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this pull request Mar 11, 2024
@ScrapCodes
Remove noninlined files for those tests, it is not required. Added a …
0ba4831 
…CI check. (kubeflow#755)

* Remove noninlined files for those tests, it is not required. Added a CI check.

* added the check to CI

* fixed the build

* fixed the build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaoning777 gaoning777 gaoning777 left review comments

@hongye-sun hongye-sun Awaiting requested review from hongye-sun

@Ark-kun Ark-kun Awaiting requested review from Ark-kun

Assignees

@IronPan IronPan

@gaoning777 gaoning777

@gyliu513 gyliu513

Labels
approved lgtm size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pipeline deploy component does not support local model
5 participants
@jinchihe @gyliu513 @gaoning777 @k8s-ci-robot @IronPan