Archive runs UI #748
Archive runs UI #748
Conversation
|
I'm not seeing the 'Archive' action on the run details page. Is there a reason it's not included on that page? UX changes:
|
|
Archive on run details page looks great. 2 pieces of feedback
|
|
Done, PTAL. I manually tweaked the breadcrumbs in the run details page to handle showing the archive piece. I think there's an opportunity to refactor this and clean it up, but since this is the only breadcrumbs exception I think it's fine. |
|
/test kubeflow-pipeline-build-image |
1 similar comment
|
/test kubeflow-pipeline-build-image |
| } | ||
| const pageTitle = <div className={commonCss.flex}> | ||
| {statusToIcon(runMetadata.status as NodePhase, runDetail.run!.created_at)} | ||
| <span style={{ marginLeft: 10 }}>{runMetadata.name!}</span> | ||
| </div>; | ||
|
|
||
| this.props.updateToolbar({ breadcrumbs, pageTitle, pageTitleTooltip: runMetadata.name }); | ||
| const buttons = new Buttons(this.props, this.refresh.bind(this)); |
There was a problem hiding this comment.
is it okay to create a new bound function here every time the page refreshes?
There was a problem hiding this comment.
You mean in terms of performance? It'd be slightly better to bind it once on the class, it's not really concerning if this code doesn't get called very frequently. If it's inside the render method, for example, it would be a little more important, but even then, there's no reason to do perf-tweaking for the run details page.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rileyjbauer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rileyjbauer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test kubeflow-pipeline-e2e-test |
* add the new gateway * remove the kfserving from the install docs * make ingress gateway a variable * make ingress gateway a variable * revert all to istio-ingress * add a note for kfserving gateway
This kicks off the archive UI experience. It only supports runs now, but more resources might be added to it in the future. The interaction is simple: select any number of runs, click archive, and confirm. You can then view the list of archived runs in the archive view, which is visible on the side nav.
Included in this PR (in file order):
optionshandlers, which are no longer needed with the React middleware.Things to improve that this PR does not tackle:
Fixes #621.
This change is