Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CMLE sample test script. #724

Merged
merged 1 commit into from
Jan 23, 2019
Merged

Conversation

qimingj
Copy link
Contributor

@qimingj qimingj commented Jan 23, 2019

The test is not added to the list to run automatically yet since it takes about 25 min.


This change is Reviewable

The test is not added to the list to run automatically yet since it takes about 25 min.
Copy link
Contributor

@gaoning777 gaoning777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

experiment_id = response.id
utils.add_junit_test(test_cases, 'create experiment', True)

###### Create Job ######
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to generalize the test script and only pass the job_name and params?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll leave it to @gaoning777 :).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

potentially it could. The reason of having multiple scripts was different checking logic for each sample. Since the sample tests generally checks whether the run succeeds(except the kubeflow_test checks the confusion matrix), we could refactor the codes.

@qimingj
Copy link
Contributor Author

qimingj commented Jan 23, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qimingj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qimingj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 4a043c1 into kubeflow:master Jan 23, 2019
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
completing the list of items for 0.3 as listed here by pointing to intial results. At some point, I will start moving them to KFServing repo itself when there is a general summarization
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this pull request Mar 11, 2024
* Reference to `kfp` SDK from 1.7.1 to 1.7.2 in sdk/python/README.md
* PyPI distro comment in sdk/python/setup.py

Signed-off-by: Christian Kadner <ckadner@us.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants