-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CMLE sample test script. #724
Conversation
The test is not added to the list to run automatically yet since it takes about 25 min.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
experiment_id = response.id | ||
utils.add_junit_test(test_cases, 'create experiment', True) | ||
|
||
###### Create Job ###### |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to generalize the test script and only pass the job_name
and params
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll leave it to @gaoning777 :).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
potentially it could. The reason of having multiple scripts was different checking logic for each sample. Since the sample tests generally checks whether the run succeeds(except the kubeflow_test checks the confusion matrix), we could refactor the codes.
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qimingj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qimingj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
completing the list of items for 0.3 as listed here by pointing to intial results. At some point, I will start moving them to KFServing repo itself when there is a general summarization
* Reference to `kfp` SDK from 1.7.1 to 1.7.2 in sdk/python/README.md * PyPI distro comment in sdk/python/setup.py Signed-off-by: Christian Kadner <ckadner@us.ibm.com>
The test is not added to the list to run automatically yet since it takes about 25 min.
This change is