Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add %%docker magic to jupyter kernel. #72

Merged
merged 2 commits into from
Nov 6, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions sdk/python/kfp/notebook/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
# Copyright 2018 Google LLC
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.


from . import _magic
42 changes: 42 additions & 0 deletions sdk/python/kfp/notebook/_magic.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
# Copyright 2018 Google LLC
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.


try:
import IPython
import IPython.core.magic
except ImportError:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks Python's official unittest module when it's applied to our standard layout.

raise Exception('This module can only be loaded in Jupyter.')


from kfp.compiler import build_docker_image
import tempfile


@IPython.core.magic.register_cell_magic
def docker(line, cell):
"""cell magic for %%docker"""

if len(line.split()) != 2:
raise ValueError("usage: %%docker [gcr.io/project/image:tag] [gs://staging-bucket]")
if not cell.strip():
raise ValueError("Please fill in a dockerfile content in the cell.")

target, staging = line.split()

with tempfile.NamedTemporaryFile(mode='wt') as f:
f.write(cell)
build_docker_image(staging, target, f.name)


1 change: 1 addition & 0 deletions sdk/python/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
'kfp.compiler',
'kfp.components',
'kfp.dsl',
'kfp.notebook',
'kfp_experiment',
'kfp_experiment.api',
'kfp_experiment.models',
Expand Down