SDK/Components - Added naming.generate_unique_name_conversion_table #716
Conversation
7ed2c63 to
5740055
Compare
generate_unique_name_conversion_table replaces _make_name_unique_by_adding_index and simplifies code in several places.
5740055 to
5964401
Compare
|
/retest |
|
/cc @gaoning777 @hongye-sun Gentle ping. |
|
@gaoning777 Would you kindly look at this small refactoring PR. |
|
@hongye-sun Maybe you can help? |
|
Other than missing the test, the PR lgtm overall. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ark-kun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ark-kun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…ubeflow#716) generate_unique_name_conversion_table replaces _make_name_unique_by_adding_index and simplifies code in several places.
* We need to upload the junits to the artifacts/junit_* directory Related to GoogleCloudPlatform/kubeflow-distribution#65
Endpoint in kfserver changed to include v1. Updated example to reflect the api change.
* Exclude files/folders that should not get rebased * Add paragraph on finding undesired code changes * Add reference to previous rebase PRs for guidance Signed-off-by: Christian Kadner <ckadner@us.ibm.com>
Extracting the function to reduce the amount of boilerplate code.
The
generate_unique_name_conversion_tablefunction replaces_make_name_unique_by_adding_indexand simplifies code in several places./assign @qimingj @gaoning777 @hongye-sun
This change is