Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK/Tests - Fixed the output ordering instability in tests #664

Merged
merged 1 commit into from
Jan 11, 2019
Merged

SDK/Tests - Fixed the output ordering instability in tests #664

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions sdk/python/tests/components/test_python_op.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ def helper_test_2_in_1_out_component_using_local_call(self, func, op):

self.assertEqual(float(actual_str), float(expected_str))

def helper_test_2_in_2_out_component_using_local_call(self, func, op):
def helper_test_2_in_2_out_component_using_local_call(self, func, op, output_names):
arg1 = float(3)
arg2 = float(5)

Expand All @@ -73,7 +73,8 @@ def helper_test_2_in_2_out_component_using_local_call(self, func, op):

process = subprocess.run(full_command)

(output_path1, output_path2) = list(task.file_outputs.values()) #Relying on the fact the file_outputs dict should be preserving the insertion order which should match the outputs order for python components. Otherwise a component spec is needed to generate the mapping.
(output_path1, output_path2) = (task.file_outputs[output_names[0]], task.file_outputs[output_names[1]])
print(task.file_outputs)
actual1_str = Path(output_path1).read_text()
actual2_str = Path(output_path2).read_text()

Expand Down Expand Up @@ -105,7 +106,7 @@ def add_multiply_two_numbers(a: float, b: float) -> NamedTuple('DummyName', [('s
func = add_multiply_two_numbers
op = comp.func_to_container_op(func)

self.helper_test_2_in_2_out_component_using_local_call(func, op)
self.helper_test_2_in_2_out_component_using_local_call(func, op, output_names=['sum', 'product'])

@unittest.skip #TODO: #Simplified multi-output syntax is not implemented yet
def test_func_to_container_op_multiple_named_typed_outputs_using_list_syntax(self):
Expand All @@ -116,7 +117,7 @@ def add_multiply_two_numbers(a: float, b: float) -> [('sum', float), ('product',
func = add_multiply_two_numbers
op = comp.func_to_container_op(func)

self.helper_test_2_in_2_out_component_using_local_call(func, op)
self.helper_test_2_in_2_out_component_using_local_call(func, op, output_names=['sum', 'product'])

def test_func_to_container_op_named_typed_outputs_with_underscores(self):
from typing import NamedTuple
Expand Down Expand Up @@ -150,7 +151,7 @@ def add_multiply_two_numbers(a: float, b: float) -> NamedTuple('DummyName', [('a
func = add_multiply_two_numbers
op = comp.func_to_container_op(func)

self.helper_test_2_in_2_out_component_using_local_call(func, op)
self.helper_test_2_in_2_out_component_using_local_call(func, op, output_names=['a', 'b'])

def test_handling_same_input_default_output_names(self):
def add_two_numbers_indented(a: float, Output: float) -> float:
Expand Down