-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(components/google-cloud): Expose all Custom Job parameters via Custom Job wrapper #6539
Merged
SinaChavoshi
merged 4 commits into
kubeflow:master
from
SinaChavoshi:custom_job_sa_cmac
Sep 13, 2021
Merged
feat(components/google-cloud): Expose all Custom Job parameters via Custom Job wrapper #6539
SinaChavoshi
merged 4 commits into
kubeflow:master
from
SinaChavoshi:custom_job_sa_cmac
Sep 13, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IronPan
reviewed
Sep 9, 2021
components/google-cloud/google_cloud_pipeline_components/experimental/custom_job/custom_job.py
Show resolved
Hide resolved
IronPan
reviewed
Sep 10, 2021
components/google-cloud/google_cloud_pipeline_components/experimental/custom_job/custom_job.py
Outdated
Show resolved
Hide resolved
components/google-cloud/google_cloud_pipeline_components/experimental/custom_job/custom_job.py
Outdated
Show resolved
Hide resolved
components/google-cloud/google_cloud_pipeline_components/experimental/custom_job/custom_job.py
Show resolved
Hide resolved
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SinaChavoshi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes adding support for Service Account , Encryption key, and Network, Tensorboard, and Base Training Dir from Vertex AI Training API in
run_as_vertex_ai_custom_job()
.